Re: [Qemu-devel] [PATCH v2 05/27] target/arm: Decode PAuth within system hint space

[Peter Maydell]

On Fri, 14 Dec 2018 at 05:24, Richard Henderson
<address@hidden> wrote:
>
> Signed-off-by: Richard Henderson <address@hidden>
> ---
>  target/arm/translate-a64.c | 93 +++++++++++++++++++++++++++++++++-----
>  1 file changed, 81 insertions(+), 12 deletions(-)
>
> diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c
> index 7c1cc1ce8e..0df344f9e8 100644
> --- a/target/arm/translate-a64.c
> +++ b/target/arm/translate-a64.c
> @@ -1471,33 +1471,102 @@ static void handle_hint(DisasContext *s, uint32_t 
> insn,
>      }
>
>      switch (selector) {
> -    case 0: /* NOP */
> -        return;
> -    case 3: /* WFI */
> +    case 000: /* NOP */
> +        break;
> +    case 003: /* WFI */

I can see why you wanted to use octal here, but I think it's
confusing (simply because octal constants are so rare and
so easy to misread). Maybe we could compromise on 0bnnnn ?
It looks like disas/riscv.c has implicitly proven that all
the compilers we care about support that...

Otherwise
Reviewed-by: Peter Maydell <address@hidden>

thanks
-- PMM