Re: [Qemu-devel] [PATCH] hw/char/stm32f2xx_usart: Do not update data register when device is disabled

[Alistair Francis]

On Fri, Jan 4, 2019 at 10:31 AM Philippe Mathieu-Daudé
<address@hidden> wrote:
>
> On 1/4/19 7:20 PM, Philippe Mathieu-Daudé wrote:
> > When the device is disable, the internal circuitry keep the data
>
> "keep" -> "keeps"
>
> > register loaded and doesn't update it.
> >
> > Signed-off-by: Philippe Mathieu-Daudé <address@hidden>

Reviewed-by: Alistair Francis <address@hidden>

Alistair

> > ---
> >  hw/char/stm32f2xx_usart.c | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/hw/char/stm32f2xx_usart.c b/hw/char/stm32f2xx_usart.c
> > index f3363a2952..10392c70e2 100644
> > --- a/hw/char/stm32f2xx_usart.c
> > +++ b/hw/char/stm32f2xx_usart.c
> > @@ -53,14 +53,13 @@ static void stm32f2xx_usart_receive(void *opaque, const 
> > uint8_t *buf, int size)
> >  {
> >      STM32F2XXUsartState *s = opaque;
> >
> > -    s->usart_dr = *buf;
> > -
> >      if (!(s->usart_cr1 & USART_CR1_UE && s->usart_cr1 & USART_CR1_RE)) {
> >          /* USART not enabled - drop the chars */
> >          DB_PRINT("Dropping the chars\n");
> >          return;
> >      }
> >
> > +    s->usart_dr = *buf;
> >      s->usart_sr |= USART_SR_RXNE;
> >
> >      if (s->usart_cr1 & USART_CR1_RXNEIE) {
> >
>