Re: [Qemu-devel] [RFC PATCH 21/25] virtio: make virtio dependencies with Kconfig

[Thomas Huth]

On 2018-12-27 07:34, Yang Zhong wrote:
> Signed-off-by: Yang Zhong <address@hidden>
> ---
>  default-configs/i386-softmmu.mak |  1 -
>  hw/9pfs/Kconfig                  |  2 ++
>  hw/block/Kconfig                 |  2 ++
>  hw/char/Kconfig                  |  2 ++
>  hw/display/Kconfig               |  5 +++++
>  hw/input/Kconfig                 |  2 ++
>  hw/net/Kconfig                   |  2 ++
>  hw/pci-host/Kconfig              |  2 ++
>  hw/virtio/Kconfig                | 10 +++++++++-
>  9 files changed, 26 insertions(+), 2 deletions(-)

Shouldn't this patch also get rid of default-configs/virtio.mak ?

[...]
> diff --git a/hw/virtio/Kconfig b/hw/virtio/Kconfig
> index aabd6d4d96..9127daed5e 100644
> --- a/hw/virtio/Kconfig
> +++ b/hw/virtio/Kconfig
> @@ -3,18 +3,26 @@ config VIRTIO
>  
>  config VIRTIO_RNG
>      bool
> +    default y
> +    depends on VIRTIO
>  
>  config VIRTIO_PCI
>      bool
>      default y
>      depends on PCI
> -    select VIRTIO
> +    depends on VIRTIO
>  
>  config VIRTIO_MMIO
>      bool
> +    default y
> +    depends on VIRTIO

I don't think we should enable VIRTIO_MMIO by default - it's only used
on arm and riscv, but not on x86 and the other architectures.

>  config VIRTIO_BALLOON
>      bool
> +    default y
> +    depends on VIRTIO
>  
>  config VIRTIO_CRYPTO
>      bool
> +    default y
> +    depends on VIRTIO
> 

 Thomas