qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 27/52] audio: use size_t where makes sense


From: Gerd Hoffmann
Subject: Re: [Qemu-devel] [PATCH v2 27/52] audio: use size_t where makes sense
Date: Mon, 7 Jan 2019 10:58:09 +0100
User-agent: NeoMutt/20180716

  Hi,

> >  void AUD_close_out (QEMUSoundCard *card, SWVoiceOut *sw);
> > -int  AUD_write (SWVoiceOut *sw, void *pcm_buf, int size);
> 
> Can you add short documentation while modifying headers? Such:
> 
> /**
>  * AUD_write:
>  *
>  * Returns: the number of bytes written.
>  */

While this certainly makes sense I don't think this should be done as
part of this patch series, it is already big enough as-is.

cheers,
  Gerd




reply via email to

[Prev in Thread] Current Thread [Next in Thread]