Re: [Qemu-devel] [PATCH v2 19/27] target/arm: Export aa64_va_parameters to internals.h

[Peter Maydell]

On Fri, 14 Dec 2018 at 05:24, Richard Henderson
<address@hidden> wrote:
>
> We need to reuse this from helper-a64.c.  Provide a stub
> definition for CONFIG_USER_ONLY.  This matches the stub
> definitions that we removed for arm_regime_tbi{0,1} before.
>
> Signed-off-by: Richard Henderson <address@hidden>
> ---
>  target/arm/internals.h | 17 +++++++++++++++++
>  target/arm/helper.c    |  4 ++--
>  2 files changed, 19 insertions(+), 2 deletions(-)
>
> diff --git a/target/arm/internals.h b/target/arm/internals.h
> index 9ef9d01ee2..4fbef58126 100644
> --- a/target/arm/internals.h
> +++ b/target/arm/internals.h
> @@ -951,4 +951,21 @@ typedef struct ARMVAParameters {
>      bool using64k   : 1;
>  } ARMVAParameters;
>
> +#ifdef CONFIG_USER_ONLY
> +static inline ARMVAParameters aa64_va_parameters(CPUARMState *env,
> +                                                 uint64_t va,
> +                                                 ARMMMUIdx mmu_idx, bool 
> data)
> +{
> +    return (ARMVAParameters) {
> +        /* 48-bit address space */
> +        .tsz = 16,

I assume 48 bits is what the kernel sets up for userspace ?

Reviewed-by: Peter Maydell <address@hidden>

thanks
-- PMM