qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC PATCH 04/25] minikconfig: add AST


From: Yang Zhong
Subject: Re: [Qemu-devel] [RFC PATCH 04/25] minikconfig: add AST
Date: Mon, 7 Jan 2019 20:06:49 +0800
User-agent: Mutt/1.5.21 (2010-09-15)

On Fri, Jan 04, 2019 at 03:13:03PM +0100, Paolo Bonzini wrote:
> On 27/12/18 07:33, Yang Zhong wrote:
> > +        self.clauses.append(KconfigData.DependsOnClause(var, expr))
> >  
> >      def do_select(self, var, symbol, cond=None):
> > -        pass
> > +        cond = (cond & var) if not (cond is None) else var
> 
> A better way to write this in Python is
> 
>     cond = (cond & var) if cond is not None else var
> 
> (My Python has improved since 2015 :)).
> 
> Paolo

  Hello Paolo,

  Thanks! i will change this in next version.

  Regards,

  Yang



reply via email to

[Prev in Thread] Current Thread [Next in Thread]