Re: [Qemu-devel] [RFC PATCH 13/25] scsi: express dependencies with Kconfig

[Yang Zhong]

On Fri, Jan 04, 2019 at 02:39:50PM +0100, Thomas Huth wrote:
> On 2018-12-27 07:34, Yang Zhong wrote:
> > From: Paolo Bonzini <address@hidden>
> > 
> > This lets you disable SCSI altogether with "CONFIG_SCSI=n".
> > 
> > Signed-off-by: Paolo Bonzini <address@hidden>
> > Signed-off-by: Yang Zhong <address@hidden>
> > ---
> >  hw/scsi/Kconfig       | 11 ++++++++++-
> >  hw/scsi/Makefile.objs |  2 +-
> >  2 files changed, 11 insertions(+), 2 deletions(-)
> > 
> > diff --git a/hw/scsi/Kconfig b/hw/scsi/Kconfig
> > index 6e7575397f..d669a4824e 100644
> > --- a/hw/scsi/Kconfig
> > +++ b/hw/scsi/Kconfig
> >  
> > -config PSERIES
> > +config SPAPR_VSCSI
> >      bool
> > +    select SCSI
> 
> I think this should get "default y" and "depends on PSERIES" now.
> 
>  Thomas

   Hello Thomas,

   I greped CONFIG_PSERIES from current Kconfig repo and got below list
  ./hw/net/Makefile.objs:obj-$(CONFIG_PSERIES) += spapr_llan.o
  ./hw/ppc/Makefile.objs:obj-$(CONFIG_PSERIES) += spapr.o spapr_caps.o 
spapr_vio.o spapr_events.o
  ./hw/ppc/Makefile.objs:obj-$(CONFIG_PSERIES) += spapr_hcall.o spapr_iommu.o 
spapr_rtas.o
  ./hw/ppc/Makefile.objs:obj-$(CONFIG_PSERIES) += spapr_pci.o spapr_rtc.o 
spapr_drc.o
  ./hw/ppc/Makefile.objs:obj-$(CONFIG_PSERIES) += spapr_cpu_core.o spapr_ovec.o 
spapr_irq.o
  ./hw/ppc/Makefile.objs:ifeq ($(CONFIG_PCI)$(CONFIG_PSERIES)$(CONFIG_LINUX), 
yyy)
  ./hw/ppc/Makefile.objs:obj-$(CONFIG_PSERIES) += spapr_rtas_ddw.o
  ./hw/char/Makefile.objs:obj-$(CONFIG_PSERIES) += spapr_vty.o
  ./hw/nvram/Makefile.objs:obj-$(CONFIG_PSERIES) += spapr_nvram.o
  ./default-configs/ppc64-softmmu.mak:CONFIG_PSERIES=y
  ./default-configs/ppc64-softmmu.mak:CONFIG_XICS=$(CONFIG_PSERIES)
  ./default-configs/ppc64-softmmu.mak:CONFIG_XICS_SPAPR=$(CONFIG_PSERIES)
  ./default-configs/ppc64-softmmu.mak:CONFIG_XICS_KVM=$(call 
land,$(CONFIG_PSERIES),$(CONFIG_KVM))

  Since this time is only for x86 and i did not add Kconfig file in hw/ppc/, i 
did not add 
  this dependency too in here. 
  
  In previous plan, i will add "config PSERRIES" in hw/ppc/Kconfig file for 
PowerPC pSeries
  and will add dependency in that time, thanks.

  Regards,

  Yang