[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Should the "props" be documented for QMP `object-add`?
From: |
Kashyap Chamarthy |
Subject: |
[Qemu-devel] Should the "props" be documented for QMP `object-add`? |
Date: |
Wed, 9 Jan 2019 09:51:13 +0100 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
I notice that the following QMP command:
{
"execute":"object-add",
"arguments":{
"qom-type":"tls-creds-x509",
"id":"objlibvirt_migrate_tls0",
"props":{
"dir":"/etc/pki/qemu",
"endpoint":"server",
"verify-peer":true
}
}
}
... is the same as its command-line equivalent:
-object
tls-creds-x509,id=tls0,dir=/etc/pki/qemu,endpoint=server,verify-peer=yes
That said, in qapi/misc.json "@object-add" doesn't document any of the
"props". Is it on purpose? Maybe because it is a 1:1 mapping of the
command-line `-object` (which _is_ documented in qemu-doc.texi).
Is it a good idea to send a patch to document the "props" in
qapi/misc.json? Or would it be needless duplication?
--
/kashyap
- [Qemu-devel] Should the "props" be documented for QMP `object-add`?,
Kashyap Chamarthy <=