[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3] s390: avoid potential null dereference ins39
|
From: |
Collin Walling |
|
Subject: |
Re: [Qemu-devel] [PATCH v3] s390: avoid potential null dereference ins390_pcihost_unplug() |
|
Date: |
Wed, 9 Jan 2019 11:07:35 -0500 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 |
On 1/8/19 10:11 AM, Li Qiang wrote:
> When getting the 'pbdev', the if...else has no default branch.
> From Coverity, the 'pbdev' maybe null when the 'dev' is not
> the TYPE_PCI_BRIDGE/TYPE_PCI_DEVICE/TYPE_S390_PCI_DEVICE.
> This patch adds a default branch for device plug and unplug.
>
> Spotted by Coverity: CID 1398593
>
> Signed-off-by: Li Qiang <address@hidden>
> ---
>
[...]
Reviewed-by: Collin Walling <address@hidden>