qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC PATCH] tests: use g_usleep instead of rem = sleep(


From: Emilio G. Cota
Subject: Re: [Qemu-devel] [RFC PATCH] tests: use g_usleep instead of rem = sleep(time)
Date: Mon, 14 Jan 2019 09:13:42 -0500
User-agent: Mutt/1.9.4 (2018-02-28)

On Mon, Jan 14, 2019 at 10:46:41 +0000, Alex Bennée wrote:
> Relying on sleep to always return having slept isn't safe as a signal
> may have occurred. If signals are constantly incoming the program will
> never reach it's termination condition. This is believed to be the
> mechanism causing time outs for qht-test in Travis.
> 
> The glib g_usleep() deals with all of this for us so lets use it instead.
> 
> Signed-off-by: Alex Bennée <address@hidden>

Reviewed-by: Emilio G. Cota <address@hidden>

Thanks,

                E.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]