[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] io: ensure UNIX client doesn't unlink server so
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH] io: ensure UNIX client doesn't unlink server socket |
Date: |
Mon, 14 Jan 2019 13:49:53 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 |
On 1/14/19 5:38 AM, Daniel P. Berrangé wrote:
> The qio_channel_socket_close method for was mistakenly unlinking the
> UNIX server socket, even if the channel was a client connection. This
> was not noticed with chardevs, since they never call close, but with the
> VNC server, this caused the VNC server socket to be deleted after the
> first client quit.
>
> The qio_channel_socket_close method also needlessly reimplemented the
> logic that already exists in socket_listen_cleanup(). Just call that
> method directly, for listen sockets only.
>
> This fixes a regression introduced in QEMU 3.0.0 with
>
> commit d66f78e1eaa832f73c771d9df1b606fe75d52a50
> Author: Pavel Balaev <address@hidden>
> Date: Mon May 21 19:17:35 2018 +0300
>
> Delete AF_UNIX socket after close
>
> Fixes launchpad #1795100
>
> Signed-off-by: Daniel P. Berrangé <address@hidden>
> ---
> io/channel-socket.c | 19 ++------
> tests/test-io-channel-socket.c | 86 ++++++++++++++++++++++++++++++----
> 2 files changed, 80 insertions(+), 25 deletions(-)
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature