Re: [Qemu-devel] [PULLv2 00/65] slirp updates

[Marc-André Lureau]

Hi

On Mon, Jan 14, 2019 at 11:19 AM Samuel Thibault
<address@hidden> wrote:
>
> address@hidden, le dim. 13 janv. 2019 19:16:44 -0800, a ecrit:
> > This series failed the address@hidden build test. Please find the testing 
> > commands and
> > their output below. If you have Docker installed, you can probably 
> > reproduce it
> > locally.
> >
> > === TEST SCRIPT BEGIN ===
> > #!/bin/bash
> > time make address@hidden SHOW_ENV=1 J=14
> > === TEST SCRIPT END ===
> >
> > The full log is available at
> > http://patchew.org/logs/address@hidden/address@hidden/?type=message.
>
> make[1]: *** No rule to make target '../slirp/arp_table.o', needed by 
> 'qemu-system-aarch64w.exe'.  Stop.

Build failure when building entirely outside of QEMU source tree, it
needs to have correct dependency set on SUBDIR_RULES targets. Please
squash in "build-sys: use a seperate slirp-obj-y && slirp.mo":

diff --git a/Makefile b/Makefile
index a9ac16d94e8..dccba1dca27 100644
--- a/Makefile
+++ b/Makefile
@@ -379,7 +379,8 @@ dummy := $(call unnest-vars,, \
                 ui-obj-m \
                 audio-obj-y \
                 audio-obj-m \
-                trace-obj-y)
+                trace-obj-y \
+                slirp-obj-y)

 include $(SRC_PATH)/tests/Makefile.include

@@ -452,7 +453,7 @@ CAP_CFLAGS += -DCAPSTONE_HAS_X86
 subdir-capstone: .git-submodule-status
        $(call quiet-command,$(MAKE) -C $(SRC_PATH)/capstone
CAPSTONE_SHARED=no BUILDDIR="$(BUILD_DIR)/capstone" CC="$(CC)"
AR="$(AR)" LD="$(LD)" RANLIB="$(RANLIB)" CFLAGS="$(CAP_CFLAGS)"
$(SUBDIR_MAKEFLAGS) $(BUILD_DIR)/capstone/$(LIBCAPSTONE))

-$(SUBDIR_RULES): libqemuutil.a $(common-obj-y) $(chardev-obj-y) \
+$(SUBDIR_RULES): libqemuutil.a $(common-obj-y) $(chardev-obj-y)
$(slirp-obj-y) \
        $(qom-obj-y) $(crypto-aes-obj-$(CONFIG_USER_ONLY))

 ROMSUBDIR_RULES=$(patsubst %,romsubdir-%, $(ROMS))

-- 
Marc-André Lureau