[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH v2 04/37] hw/m68k/Makefile.objs: Conditional
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [RFC PATCH v2 04/37] hw/m68k/Makefile.objs: Conditionally build boards |
Date: |
Wed, 16 Jan 2019 08:15:23 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 2019-01-15 15:10, Yang Zhong wrote:
> From: Ákos Kovács <address@hidden>
>
> CONFIG_AN5206, CONFIG_MCF5206 and CONFIG_MCF5208 make
> variables created for m68k boards, and added to
> default-configs/m86k-softmmu.mak.
>
> Signed-off-by: Ákos Kovács <address@hidden>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> default-configs/m68k-softmmu.mak | 3 +++
> hw/m68k/Makefile.objs | 5 +++--
> 2 files changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/default-configs/m68k-softmmu.mak
> b/default-configs/m68k-softmmu.mak
> index 60f7cdfbf2..a179da9077 100644
> --- a/default-configs/m68k-softmmu.mak
> +++ b/default-configs/m68k-softmmu.mak
> @@ -2,3 +2,6 @@
>
> CONFIG_COLDFIRE=y
> CONFIG_PTIMER=y
> +CONFIG_AN5206=y
> +CONFIG_MCF5206=y
> +CONFIG_MCF5208=y
> diff --git a/hw/m68k/Makefile.objs b/hw/m68k/Makefile.objs
> index d1f089c08a..fa287edd0b 100644
> --- a/hw/m68k/Makefile.objs
> +++ b/hw/m68k/Makefile.objs
> @@ -1,2 +1,3 @@
> -obj-y += an5206.o mcf5208.o
> -obj-y += mcf5206.o mcf_intc.o
> +obj-$(CONFIG_AN5206) += an5206.o
> +obj-$(CONFIG_MCF5206) += mcf5206.o
> +obj-$(CONFIG_MCF5208) += mcf5208.o mcf_intc.o
The naming of the files is a little bit unfortunate, but
there are only two Coldfire boards: an5206 and mcf5208evb.
mcf5206.c belongs to the an5206 board.
So may I suggest to only use two CONFIG switches like this:
obj-$(CONFIG_AN5206) += an5206.o mcf5206.o
obj-$(CONFIG_MCF5208EVB) += mcf5208.o mcf_intc.o
?
Thanks,
Thomas
- [Qemu-devel] [RFC PATCH v2 01/37] build: actually use CONFIG_PAM, (continued)
- [Qemu-devel] [RFC PATCH v2 01/37] build: actually use CONFIG_PAM, Yang Zhong, 2019/01/15
- [Qemu-devel] [RFC PATCH v2 03/37] hw/arm/Makefile.objs: CONFIG_VIRT created for virt board, Yang Zhong, 2019/01/15
- [Qemu-devel] [RFC PATCH v2 16/37] minikconfig: add AST, Yang Zhong, 2019/01/15
- [Qemu-devel] [RFC PATCH v2 08/37] hw/sh4/Makefile.objs: New CONFIG_* varibales created for sh4 boards and device, Yang Zhong, 2019/01/15
- [Qemu-devel] [RFC PATCH v2 02/37] hw/i386/Makefile.objs: Build pc_piix* and pc_q35 boards, Yang Zhong, 2019/01/15
- [Qemu-devel] [RFC PATCH v2 04/37] hw/m68k/Makefile.objs: Conditionally build boards, Yang Zhong, 2019/01/15
- Re: [Qemu-devel] [RFC PATCH v2 04/37] hw/m68k/Makefile.objs: Conditionally build boards,
Thomas Huth <=
- Re: [Qemu-devel] [RFC PATCH v2 00/37] Support Kconfig in QEMU, Paolo Bonzini, 2019/01/15
- Re: [Qemu-devel] [RFC PATCH v2 00/37] Support Kconfig in QEMU, Thomas Huth, 2019/01/16