[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 4/4] hw/i386/pc: use PVH option rom
From: |
Stefano Garzarella |
Subject: |
Re: [Qemu-devel] [PATCH v2 4/4] hw/i386/pc: use PVH option rom |
Date: |
Wed, 16 Jan 2019 09:22:37 +0100 |
User-agent: |
NeoMutt/20180716 |
Hi Eric,
On Tue, Jan 15, 2019 at 01:12:21PM -0600, Eric Blake wrote:
> On 1/15/19 12:57 PM, Michael S. Tsirkin wrote:
> > On Tue, Jan 15, 2019 at 11:00:58AM +0100, Stefano Garzarella wrote:
> >> Use pvh.bin option rom when we are booting an uncompressed
> >> kernel using the x86/HVM direct boot ABI.
> >>
> >> Signed-off-by: Stefano Garzarella <address@hidden>
> >> Based-on: <address@hidden>
> >
> > I don't think this is a great way to give attribution.
> > Can you pls include the author name and the S.O.B from there as well?
> >
> >
> >> ---
>
> Patchew understands Based-on: tags as meaning a prerequisite patch on
> the list that must be applied first before this patch can apply (and NOT
> in the sense that this patch is an updated revision to replace an
> earlier revision posted by someone else) - but when using the annotation
> to keep Patchew happy, it should either be in a 0/N cover letter, or for
> a single patch, after the --- separator, as the condition of a
> prerequisite patch not being applied is a transient condition relevant
> to the current build but not something that needs to be recorded in
> long-term git history.
>
Thank you very much for the explanation! I'll move the Based-on tag in
the cover letter.
Cheers,
Stefano
[Qemu-devel] [PATCH v2 3/4] optionrom: add new PVH option rom, Stefano Garzarella, 2019/01/15
[Qemu-devel] [PATCH v2 1/4] linuxboot_dma: remove duplicate definitions of FW_CFG, Stefano Garzarella, 2019/01/15
[Qemu-devel] [PATCH v2 2/4] linuxboot_dma: move common functions in a new header, Stefano Garzarella, 2019/01/15
Re: [Qemu-devel] [PATCH v2 0/4] pvh: add new PVH option rom, Stefan Hajnoczi, 2019/01/15
Re: [Qemu-devel] [PATCH v2 0/4] pvh: add new PVH option rom, Liam Merwick, 2019/01/16