[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] hw/block/xen: use proper format string for prin
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [Qemu-devel] [PATCH] hw/block/xen: use proper format string for printing sectors |
|
Date: |
Wed, 16 Jan 2019 14:04:34 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1 |
On 1/16/19 1:19 PM, Paul Durrant wrote:
>> -----Original Message-----
>> From: Alex Bennée [mailto:address@hidden
>> Sent: 16 January 2019 12:14
>> To: address@hidden
>> Cc: address@hidden; Alex Bennée <address@hidden>; Stefano
>> Stabellini <address@hidden>; Anthony Perard
>> <address@hidden>; Paul Durrant <address@hidden>; Kevin
>> Wolf <address@hidden>; Max Reitz <address@hidden>; open list:X86
>> <address@hidden>; open list:Block layer core <qemu-
>> address@hidden>
>> Subject: [PATCH] hw/block/xen: use proper format string for printing
>> sectors
>>
>> The %lu format string is different depending on the host architecture
>> which causes builds like the debian-armhf-cross build to fail. Use the
>> correct PRi64 format string.
>>
>> Signed-off-by: Alex Bennée <address@hidden>
>
> This does the same thing as "xen: Fix format string" from Philippe, but this
> variant is better...
OK.
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
>
> Reviewed-by: Paul Durrant <address@hidden>
>
>> ---
>> hw/block/xen-block.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/hw/block/xen-block.c b/hw/block/xen-block.c
>> index be28b63442..a636487b3e 100644
>> --- a/hw/block/xen-block.c
>> +++ b/hw/block/xen-block.c
>> @@ -215,7 +215,7 @@ static void xen_block_realize(XenDevice *xendev, Error
>> **errp)
>>
>> xen_device_backend_printf(xendev, "sector-size", "%u",
>> conf->logical_block_size);
>> - xen_device_backend_printf(xendev, "sectors", "%lu",
>> + xen_device_backend_printf(xendev, "sectors", "%"PRIi64,
>> blk_getlength(conf->blk) /
>> conf->logical_block_size);
>>
>> --
>> 2.17.1
>