Re: [Qemu-devel] [PATCH v2 43/52] audio: add mixeng option (documentation)

[Eric Blake]

On 1/16/19 2:27 PM, Zoltán Kővágó wrote:

>>> +++ b/qapi/audio.json
>>> @@ -184,6 +184,10 @@
>>>  #
>>>  # General audio backend options that are used for both playback and 
>>> recording.
>>>  #
>>> +# @mixeng: #optional use QEMU's mixing engine to mix all streams inside 
>>> QEMU.
>>
>> The #optional tag is no longer necessary (the docs generator figures it
>> out from the '*mixeng' name below).
> 
> Ok.
> 
>>> +#          When set to off, fixed-settings must be also off.  Not every 
>>> backend
>>> +#          compatible with the off setting (default on)
>>
>> Missing a '(since 4.0)' tag.
> 
> The whole AudiodevPerDirectionOptions struct is marked with 'Since:
> 4.0', so I don't think it's necessary.

Oh right. It's less common to see incremental additions to a type within
a single release, but you are right that the per-member tag is only
needed when an older release exposed the type you are extending.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

signature.asc
Description: OpenPGP digital signature