[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v10 12/24] replay: introduce breakpoint at the s
From: |
Pavel Dovgalyuk |
Subject: |
Re: [Qemu-devel] [PATCH v10 12/24] replay: introduce breakpoint at the specified step |
Date: |
Fri, 18 Jan 2019 08:34:59 +0300 |
> From: Markus Armbruster [mailto:address@hidden
> Pavel Dovgalyuk <address@hidden> writes:
>
> > This patch introduces replay_break, replay_delete_break
> > qmp and hmp commands.
> > These commands allow stopping at the specified instruction.
> > It may be useful for debugging when there are some known
> > events that should be investigated.
> > replay_break command has one argument - number of instructions
> > executed since the start of the replay.
> > replay_delete_break removes previously set breakpoint.
> >
> > Signed-off-by: Pavel Dovgalyuk <address@hidden>
> >
> > --
> > +
> > +static void replay_break(uint64_t icount, QEMUTimerCB callback, void
> > *opaque)
> > +{
> > + assert(replay_mode == REPLAY_MODE_PLAY);
> > + assert(replay_mutex_locked());
> > + assert(replay_break_icount >= replay_get_current_step());
>
> The identifier replay_get_current_step() is one of the few remaining
> instances of "step" terminology. Whether to normalize them to "icount"
> is entirely up to you.
This is already done with the last patch in the series.
Pavel Dovgalyuk
- [Qemu-devel] [PATCH v10 07/24] qcow2: introduce icount field for snapshots, (continued)
- [Qemu-devel] [PATCH v10 07/24] qcow2: introduce icount field for snapshots, Pavel Dovgalyuk, 2019/01/17
- [Qemu-devel] [PATCH v10 09/24] replay: provide an accessor for rr filename, Pavel Dovgalyuk, 2019/01/17
- [Qemu-devel] [PATCH v10 08/24] migration: introduce icount field for snapshots, Pavel Dovgalyuk, 2019/01/17
- [Qemu-devel] [PATCH v10 10/24] qapi: introduce replay.json for record/replay-related stuff, Pavel Dovgalyuk, 2019/01/17
- [Qemu-devel] [PATCH v10 11/24] replay: introduce info hmp/qmp command, Pavel Dovgalyuk, 2019/01/17
- [Qemu-devel] [PATCH v10 12/24] replay: introduce breakpoint at the specified step, Pavel Dovgalyuk, 2019/01/17
- [Qemu-devel] [PATCH v10 13/24] replay: implement replay-seek command, Pavel Dovgalyuk, 2019/01/17
- [Qemu-devel] [PATCH v10 14/24] replay: refine replay-time module, Pavel Dovgalyuk, 2019/01/17
- [Qemu-devel] [PATCH v10 15/24] replay: flush rr queue before loading the vmstate, Pavel Dovgalyuk, 2019/01/17
- [Qemu-devel] [PATCH v10 16/24] gdbstub: add reverse step support in replay mode, Pavel Dovgalyuk, 2019/01/17
- [Qemu-devel] [PATCH v10 18/24] replay: describe reverse debugging in docs/replay.txt, Pavel Dovgalyuk, 2019/01/17
- [Qemu-devel] [PATCH v10 17/24] gdbstub: add reverse continue support in replay mode, Pavel Dovgalyuk, 2019/01/17
- [Qemu-devel] [PATCH v10 19/24] replay: add BH oneshot event for block layer, Pavel Dovgalyuk, 2019/01/17
- [Qemu-devel] [PATCH v10 20/24] replay: init rtc after enabling the replay, Pavel Dovgalyuk, 2019/01/17
- [Qemu-devel] [PATCH v10 21/24] replay: document development rules, Pavel Dovgalyuk, 2019/01/17