Re: [Qemu-devel] [PATCH 4/5] tests/libqos: embed allocators instead of malloc-ing them separately

[Paolo Bonzini]

On 18/01/19 13:52, Thomas Huth wrote:
> 
>> +                uint64_t start, uint64_t end,
>> +                size_t page_size)
>>  {
>> -    QGuestAllocator *s = g_malloc0(sizeof(*s));
>>      MemBlock *node;
>>  
>>      s->start = start;
>> @@ -313,26 +301,7 @@ QGuestAllocator *alloc_init(uint64_t start, uint64_t 
>> end)
>>      node = mlist_new(s->start, s->end - s->start);
>>      QTAILQ_INSERT_HEAD(s->free, node, MLIST_ENTNAME);
>>  
>> -    s->page_size = DEFAULT_PAGE_SIZE;
>> -
>> -    return s;
>> -}
>> -
>> -QGuestAllocator *alloc_init_flags(QAllocOpts opts,
>> -                                  uint64_t start, uint64_t end)
>> -{
>> -    QGuestAllocator *s = alloc_init(start, end);
>> -    s->opts = opts;
> i.e. keep this line ^ ?
> 

I'll add the line back.  It's used by the legacy QOSOps.

Paolo