Re: [Qemu-devel] [PATCH v2 4/4] trace: add ability to do simple printf logging via systemtap

[Stefan Hajnoczi]

On Fri, Jan 18, 2019 at 12:14:14PM -0600, Eric Blake wrote:
> On 1/18/19 11:31 AM, Daniel P. Berrangé wrote:
> > +def c_macro_to_format(macro):
> > +    if macro.startswith("PRI"):
> > +        return macro[3]
> > +
> > +    if macro == "TARGET_FMT_plx":
> > +        return "%016x"
> 
> Do we really want to permit TARGET_FMT in our trace-events files, or
> should that be fixed in hw/tpm/trace-events?  See commit 73ff0610.

TARGET_FMT_plx is constant across all QEMU targets.  I think supporting
it is nice since it makes writing trace events more natural/convenient.

Stefan

signature.asc
Description: PGP signature