[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] configure: Don't add Xen's libs to LDFLAGS
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [Qemu-devel] [PATCH] configure: Don't add Xen's libs to LDFLAGS |
|
Date: |
Mon, 21 Jan 2019 16:15:47 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 |
On 1/21/19 3:48 PM, Anthony PERARD wrote:
> When Xen is detected via pkg-config, it isn't necessary to modify
> LDFLAGS as modifying libs_softmmu is enough.
>
> Reported-by: Peter Maydell <address@hidden>
> Signed-off-by: Anthony PERARD <address@hidden>
> ---
> configure | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/configure b/configure
> index 12fd34f30b..98b270974d 100755
> --- a/configure
> +++ b/configure
> @@ -2355,7 +2355,6 @@ if test "$xen" != "no" ; then
> fi
> QEMU_CFLAGS="$QEMU_CFLAGS $($pkg_config --cflags $xen_pc)"
> libs_softmmu="$($pkg_config --libs $xen_pc) $libs_softmmu"
> - LDFLAGS="$($pkg_config --libs $xen_pc) $LDFLAGS"
> else
>
> xen_libs="-lxenstore -lxenctrl -lxenguest"
>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>