[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 18/49] tests/hexloader-test: Don't pass -nographic to
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PULL 18/49] tests/hexloader-test: Don't pass -nographic to the QEMU under test |
Date: |
Mon, 21 Jan 2019 19:05:49 +0100 |
From: Peter Maydell <address@hidden>
The hexloader test invokes QEMU with the -nographic argument. This
is unnecessary, because the qtest_initf() function will pass it
-display none, which suffices to disable the graphical window.
It also means that the QEMU process will make the stdin/stdout
O_NONBLOCK. Since O_NONBLOCK is not per-file descriptor but per
"file description", this non-blocking behaviour is then shared
with any other process that's using the stdin/stdout of the
'make check' run, including make itself. This can result in make
falling over with "make: write error: stdout" because it got
an unexpected EINTR trying to write output messages to the terminal.
This is particularly noticable if running 'make check' in a loop with
while make check; do true; done
(It does not affect single make check runs so much because the
shell will remove the O_NONBLOCK status before it reads the
terminal for interactive input.)
Remove the unwanted -nographic argument.
Signed-off-by: Peter Maydell <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
---
tests/hexloader-test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/hexloader-test.c b/tests/hexloader-test.c
index 834ed52..8b7aa2d 100644
--- a/tests/hexloader-test.c
+++ b/tests/hexloader-test.c
@@ -23,7 +23,7 @@ static void hex_loader_test(void)
const unsigned int base_addr = 0x00010000;
QTestState *s = qtest_initf(
- "-M vexpress-a9 -nographic -device
loader,file=tests/data/hex-loader/test.hex");
+ "-M vexpress-a9 -device loader,file=tests/data/hex-loader/test.hex");
for (i = 0; i < 256; ++i) {
uint8_t val = qtest_readb(s, base_addr + i);
--
1.8.3.1
- [Qemu-devel] [PULL 17/49] tap: flush STDOUT on newline, (continued)
- [Qemu-devel] [PULL 17/49] tap: flush STDOUT on newline, Paolo Bonzini, 2019/01/21
- [Qemu-devel] [PULL 19/49] cpu-exec: add assert_no_pages_locked() after longjmp, Paolo Bonzini, 2019/01/21
- [Qemu-devel] [PULL 14/49] vhost-user-test: create a main loop per TestServer, Paolo Bonzini, 2019/01/21
- [Qemu-devel] [PULL 20/49] cpu-exec: reset BQL after longjmp in cpu_exec_step_atomic, Paolo Bonzini, 2019/01/21
- [Qemu-devel] [PULL 12/49] vhost-user-test: skip if there is no memory at address 0, Paolo Bonzini, 2019/01/21
- [Qemu-devel] [PULL 03/49] vhost-net: move stubs to a separate file, Paolo Bonzini, 2019/01/21
- [Qemu-devel] [PULL 13/49] vhost-user-test: reduce usage of global_qtest, Paolo Bonzini, 2019/01/21
- [Qemu-devel] [PULL 05/49] vhost: restrict Linux dependency to kernel vhost, Paolo Bonzini, 2019/01/21
- [Qemu-devel] [PULL 15/49] vhost-user-test: small changes to init_hugepagefs, Paolo Bonzini, 2019/01/21
- [Qemu-devel] [PULL 16/49] vhost-user-test: create a temporary directory per TestServer, Paolo Bonzini, 2019/01/21
- [Qemu-devel] [PULL 18/49] tests/hexloader-test: Don't pass -nographic to the QEMU under test,
Paolo Bonzini <=
- [Qemu-devel] [PULL 21/49] configure: Add a proper check for openpty() in libutil, Paolo Bonzini, 2019/01/21
- [Qemu-devel] [PULL 22/49] cpus: ignore ESRCH in qemu_cpu_kick_thread(), Paolo Bonzini, 2019/01/21
- [Qemu-devel] [PULL 24/49] elf-ops.h: Add get_elf_note_type(), Paolo Bonzini, 2019/01/21
- [Qemu-devel] [PULL 25/49] pvh: Add x86/HVM direct boot ABI header file, Paolo Bonzini, 2019/01/21
- [Qemu-devel] [PULL 28/49] linuxboot_dma: remove duplicate definitions of FW_CFG, Paolo Bonzini, 2019/01/21
- [Qemu-devel] [PULL 23/49] elf: Add optional function ptr to load_elf() to parse ELF notes, Paolo Bonzini, 2019/01/21
- [Qemu-devel] [PULL 31/49] optionrom/pvh: load initrd from fw_cfg, Paolo Bonzini, 2019/01/21
- [Qemu-devel] [PULL 32/49] i386: remove the new CPUID 'PCONFIG' from Icelake-Server CPU model, Paolo Bonzini, 2019/01/21
- [Qemu-devel] [PULL 36/49] contrib/elf2dmp: fix elf.h including, Paolo Bonzini, 2019/01/21
- [Qemu-devel] [PULL 30/49] hw/i386/pc: use PVH option rom, Paolo Bonzini, 2019/01/21