Re: [Qemu-devel] [PATCH] virtio-net: Fix VirtIONet typedef redefinition

[Michael S. Tsirkin]

On Tue, Jan 22, 2019 at 06:23:34AM +0100, Thomas Huth wrote:
> On 2019-01-22 06:05, Michael S. Tsirkin wrote:
> > On Tue, Jan 22, 2019 at 05:28:12AM +0100, Thomas Huth wrote:
> >> On 2019-01-21 20:46, Philippe Mathieu-Daudé wrote:
> >>> On 1/21/19 8:22 PM, Eric Blake wrote:
> >>>> On 1/21/19 12:10 PM, Philippe Mathieu-Daudé wrote:
> >>>>> Commit 2974e916df8 introduced the VirtioNetRscChain structure which
> >>>>> refer to a VirtIONet, declared later, thus required VirtIONet typedef
> >>>>> to be declarated forward.
> >>>>
> >>>> s/be declarated forward/use a forward declaration/
> >>>
> >>> Thanks Eric.
> >>>
> >>> Thomas, do you mind fixing this if you take this patch?
> >>
> >> No problem, just fixed it while picking up the patch.
> > 
> > I'm not sure why it's going through that tree but sure go ahead.
> 
> Sorry, I certainly don't want to step on your toes here. I just need
> this patch to fix compilation with "-std=gnu99" which is required for
> the patch in my PULL request that enables this compiler flag there:
> 
> https://lists.gnu.org/archive/html/qemu-devel/2019-01/msg02695.html

Oh. Your tree makes sense then.

> > Sent Reviewed-by tag.
> 
> Thanks a lot!
> 
>  Thomas