Re: [Qemu-devel] [PATCH 08/11] target/arm: Add guarded_pages cpu property for user-only

[Peter Maydell]

On Tue, 22 Jan 2019 at 15:42, Richard Henderson
<address@hidden> wrote:
>
> On 1/22/19 7:29 AM, Peter Maydell wrote:
> > On Thu, 10 Jan 2019 at 12:18, Richard Henderson
> > <address@hidden> wrote:
> >>
> >> While waiting for a proper userland ABI, allow static test
> >> cases to be written assuming that GP is set for all pages.
> >>
> >> Signed-off-by: Richard Henderson <address@hidden>
> >> ---
> >>  target/arm/cpu.h           |  4 ++++
> >>  target/arm/cpu64.c         | 18 ++++++++++++++++++
> >>  target/arm/translate-a64.c |  8 +++++++-
> >>  3 files changed, 29 insertions(+), 1 deletion(-)
> >
> > This is OK code-wise but I'm a bit wary of committing it
> > because then we're stuck with the property forever even
> > if it turns out to be irrelevant to whatever the userland
> > ABI eventually is.
>
> That's surely simply a matter of documentation.
> "Don't rely on this property: it will go away."

Convention is that those should be prefixed with "x-".

thanks
-- PMM