qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] audio: fix pc speaker init


From: no-reply
Subject: Re: [Qemu-devel] [PATCH] audio: fix pc speaker init
Date: Wed, 23 Jan 2019 11:12:08 -0800 (PST)

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Type: series
Subject: [Qemu-devel] [PATCH] audio: fix pc speaker init

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
a762b28 audio: fix pc speaker init

=== OUTPUT BEGIN ===
ERROR: space prohibited between function name and open parenthesis '('
#63: FILE: hw/audio/pcspk.c:175:
+        error_setg (errp, "Initializing audio voice failed");

ERROR: space prohibited between function name and open parenthesis '('
#85: FILE: hw/audio/pcspk.c:227:
+    isa_create_simple (bus, TYPE_PC_SPEAKER);

total: 2 errors, 0 warnings, 70 lines checked

Commit a762b288e328 (audio: fix pc speaker init) has style problems, please 
review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden

reply via email to

[Prev in Thread] Current Thread [Next in Thread]