Re: [Qemu-devel] [RFC PATCH v4 41/44] virtio: make virtio dependencies with Kconfig

[Thomas Huth]

On 2019-01-23 07:56, Yang Zhong wrote:
> Signed-off-by: Yang Zhong <address@hidden>
> Reviewed-by: Thomas Huth <address@hidden>
> ---
>  default-configs/i386-softmmu.mak  |  1 -
>  default-configs/s390x-softmmu.mak |  1 -
>  default-configs/virtio.mak        | 15 ---------------
>  hw/9pfs/Kconfig                   |  2 ++
>  hw/block/Kconfig                  |  2 ++
>  hw/char/Kconfig                   |  2 ++
>  hw/display/Kconfig                |  5 +++++
>  hw/input/Kconfig                  |  2 ++
>  hw/net/Kconfig                    |  2 ++
>  hw/pci-host/Kconfig               |  2 ++
>  hw/scsi/Kconfig                   |  1 +
>  hw/virtio/Kconfig                 |  9 ++++++++-
>  12 files changed, 26 insertions(+), 18 deletions(-)
>  delete mode 100644 default-configs/virtio.mak

This breaks compilation of aarch64 / arm as long as these targets are
not fully converted yet:

Exception: contradiction between clauses when setting VIRTIO_MMIO
make: *** No rule to make target `aarch64-softmmu/config-devices.mak',
needed by `config-all-devices.mak'.  Stop.

I think you temporarily have not to set CONFIG_VIRTIO=y in
default-configs/arm-softmmu.mak (and likely also in the riscv and s390x
configs), until they are finally converted completely?

 Thomas