[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] trace: rerun tracetool after ./configure change
|
From: |
Daniel P . Berrangé |
|
Subject: |
Re: [Qemu-devel] [PATCH] trace: rerun tracetool after ./configure changes |
|
Date: |
Tue, 29 Jan 2019 10:44:23 +0000 |
|
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On Tue, Jan 29, 2019 at 10:53:43AM +0800, Stefan Hajnoczi wrote:
> Autogenerated code in trace.h/trace.c and friends is specific to the
> config-host.mak TRACE_BACKENDS setting and must be regenerated when
> ./configure --enable-trace-backend= changes settings.
>
> This patch ensures that changes to TRACE_BACKENDS are detected. For
> example, the trace-root.h file is now updated after switching trace
> backends:
>
> $ ./configure && make
> $ cp trace-root.h /tmp/old-trace-root.h
> $ ./configure --enable-trace-backend=simple && make
> $ diff -u /tmp/old-trace-root.h trace-root.h
>
> Reported-by: Christophe Lyon <address@hidden>
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> ---
> Makefile | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
Reviewed-by: Daniel P. Berrangé <address@hidden>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|