Re: [Qemu-devel] [PATCH 7/9] qmp: Add announce-self command

[Dr. David Alan Gilbert]

* Eric Blake (address@hidden) wrote:
> On 1/28/19 11:03 AM, Dr. David Alan Gilbert (git) wrote:
> > From: "Dr. David Alan Gilbert" <address@hidden>
> > 
> > Add a qmp command that can trigger guest announcements.
> > 
> > It uses it's own announce-timer instance, and parameters
> 
> s/it's/its/ (here, you want the possessive form without apostrophe; the
> contraction form is correct only when you can use "it is" in the same place)

' removed

> > passed to it explicitly in the command.
> > 
> > Like most qmp commands, it's in the main thread/bql, so
> 
> Here, "it's" is correct.
> 
> > there's no racing with any outstanding timer.
> > 
> > Based on work of Germano Veit Michel <address@hidden> and
> >                  Vladislav Yasevich <address@hidden>
> > 
> > Signed-off-by: Dr. David Alan Gilbert <address@hidden>
> > ---
> >  net/announce.c |  8 ++++++++
> >  qapi/net.json  | 20 ++++++++++++++++++++
> >  2 files changed, 28 insertions(+)
> > 
> 
> > +++ b/qapi/net.json
> > @@ -707,3 +707,23 @@
> >              'max': 'int',
> >              'rounds': 'int',
> >              'step': 'int' } }
> > +
> > +##
> > +# @announce-self:
> > +#
> > +# Trigger generation of broadcast RARP frames to update network switches.
> > +# This can be useful when network bonds fail-over the active slave.
> > +#
> > +# @params: AnnounceParameters giving timing and repetition count of 
> > announce
> > +#
> > +# Example:
> > +#
> > +# -> { "execute": "announce-self"
> > +#      "arguments": { "initial": 50, "max": 550, "rounds": 10, "step": 50 
> > } }
> 
> Again, can any of these have useful defaults to be left optional?

Nope, you have to state what you want fully.
However, that line is actually wrong, it should be:
# -> { "execute": "announce-self"
#      "arguments": { "params:" {
#          "initial": 50, "max": 550, "rounds": 10, "step": 50 } } }

(As I found when I wrote the test).
I've fixed that up.

Dave

> > +# <- { "return": {} }
> > +#
> > +# Since: 4.0
> > +##
> > +{ 'command': 'announce-self',
> > +  'data' : {'params': 'AnnounceParameters'} }
> > +
> > 
> 
> -- 
> Eric Blake, Principal Software Engineer
> Red Hat, Inc.           +1-919-301-3226
> Virtualization:  qemu.org | libvirt.org
> 



--
Dr. David Alan Gilbert / address@hidden / Manchester, UK