[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/5] make: don't insert a '/' after $(DESTDIR)
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 2/5] make: don't insert a '/' after $(DESTDIR) |
Date: |
Tue, 29 Jan 2019 15:09:44 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 |
On 1/29/19 5:39 AM, Daniel P. Berrangé wrote:
> This breaks when $(prefix) is a relative directory, as it turns it
> into an absolute path.
>
> Signed-off-by: Daniel P. Berrangé <address@hidden>
> ---
> Makefile | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
Yes, it is long-standing practice among Automake and others that
$(DESTDIR) is normally empty but should contain its own trailing slash
when defined, as it is NOT separated from the rest of the installation
lines with an explicit /.
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 0/5] misc fixes to deal with icon location changes, Daniel P . Berrangé, 2019/01/29
- [Qemu-devel] [PATCH 5/5] configure: stop trying to link non-existant bmp file from bios dir, Daniel P . Berrangé, 2019/01/29
- [Qemu-devel] [PATCH 2/5] make: don't insert a '/' after $(DESTDIR), Daniel P . Berrangé, 2019/01/29
- Re: [Qemu-devel] [PATCH 2/5] make: don't insert a '/' after $(DESTDIR),
Eric Blake <=
- [Qemu-devel] [PATCH 1/5] nsis: don't install files into /tmp, Daniel P . Berrangé, 2019/01/29
- [Qemu-devel] [PATCH 3/5] nsis: ensure we always pass -W64 flag to nsis installer script, Daniel P . Berrangé, 2019/01/29
- [Qemu-devel] [PATCH 4/5] nsis: fix location of icons to be bundled in the installer, Daniel P . Berrangé, 2019/01/29