qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] egl-helpers.h: do not depend on X11 Window type


From: no-reply
Subject: Re: [Qemu-devel] [PATCH] egl-helpers.h: do not depend on X11 Window type, use EGLNativeWindowType
Date: Thu, 31 Jan 2019 08:36:52 -0800 (PST)

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH] egl-helpers.h: do not depend on X11 Window type, 
use EGLNativeWindowType
Message-id: address@hidden
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
e9b284a egl-helpers.h: do not depend on X11 Window type, use EGLNativeWindowType

=== OUTPUT BEGIN ===
ERROR: line over 90 characters
#57: FILE: ui/gtk-egl.c:57:
+    vc->gfx.esurface = qemu_egl_init_surface_x11(vc->gfx.ectx, 
(EGLNativeWindowType)x11_window);

total: 1 errors, 0 warnings, 32 lines checked

Commit e9b284a96c5d (egl-helpers.h: do not depend on X11 Window type, use 
EGLNativeWindowType) has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden

reply via email to

[Prev in Thread] Current Thread [Next in Thread]