Re: [Qemu-devel] [PATCH v2 0/6] audio: rework driver probing.

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH v2 0/6] audio: rework driver probing.
Type: series
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
fea799eca6 audio: probe audio drivers by default
722a65b21c audio: error message tweak
1db7b38a1f audio: check for pulseaudio daemon pidfile
fdf2993915 audio: use try-sdl for openbsd
7ab8105158 audio: allow optional audio drivers.
c971b5eb6b audio: use pkg-config

=== OUTPUT BEGIN ===
1/6 Checking commit c971b5eb6b54 (audio: use pkg-config)
2/6 Checking commit 7ab810515823 (audio: allow optional audio drivers.)
3/6 Checking commit fdf2993915d6 (audio: use try-sdl for openbsd)
4/6 Checking commit 1db7b38a1f9d (audio: check for pulseaudio daemon pidfile)
ERROR: braces {} are necessary for all arms of this statement
#31: FILE: audio/paaudio.c:823:
+        if (!runtime)
[...]

ERROR: braces {} are necessary for all arms of this statement
#34: FILE: audio/paaudio.c:826:
+        if (stat(pidfile, &st) != 0)
[...]

total: 2 errors, 0 warnings, 19 lines checked

Patch 4/6 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

5/6 Checking commit 722a65b21c13 (audio: error message tweak)
ERROR: space prohibited between function name and open parenthesis '('
#22: FILE: audio/audio.c:1765:
+static int audio_driver_init (AudioState *s, struct audio_driver *drv, bool 
msg)

ERROR: braces {} are necessary for all arms of this statement
#31: FILE: audio/audio.c:1779:
+        if (msg)
[...]

ERROR: space prohibited between function name and open parenthesis '('
#32: FILE: audio/audio.c:1780:
+            dolog ("Could not init `%s' audio driver\n", drv->name);

total: 3 errors, 0 warnings, 41 lines checked

Patch 5/6 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

6/6 Checking commit fea799eca604 (audio: probe audio drivers by default)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden