Re: [Qemu-devel] [PATCH v4 00/14] Audio patches (was: Audio 5.1 patches)

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH v4 00/14] Audio patches (was: Audio 5.1 patches)
Type: series
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
9505d0ef85 audio: -audiodev command line option: cleanup
2f7a6267e8 wavaudio: port to -audiodev config
53f2b38246 spiceaudio: port to -audiodev config
83031a0586 sdlaudio: port to -audiodev config
a4cf2daf95 paaudio: port to -audiodev config
eca548aefa ossaudio: port to -audiodev config
96b7a11f8e noaudio: port to -audiodev config
01d330b3a7 dsoundaudio: port to -audiodev config
3738935850 coreaudio: port to -audiodev config
a2c88d6cd0 alsaaudio: port to -audiodev config
54e5804b4c audio: -audiodev command line option basic implementation
172a851936 audio: -audiodev command line option: documentation
a418745d8a audio: use qapi AudioFormat instead of audfmt_e
820a94e64b qapi: qapi for audio backends

=== OUTPUT BEGIN ===
1/14 Checking commit 820a94e64b20 (qapi: qapi for audio backends)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#51: 
new file mode 100644

total: 0 errors, 1 warnings, 246 lines checked

Patch 1/14 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/14 Checking commit a418745d8ae2 (audio: use qapi AudioFormat instead of 
audfmt_e)
ERROR: space prohibited between function name and open parenthesis '('
#36: FILE: audio/alsaaudio.c:297:
+static snd_pcm_format_t aud_to_alsafmt (AudioFormat fmt, int endianness)

ERROR: space prohibited between function name and open parenthesis '('
#84: FILE: audio/alsaaudio.c:347:
+static int alsa_to_audfmt (snd_pcm_format_t alsafmt, AudioFormat *fmt,

ERROR: space prohibited between function name and open parenthesis '('
#205: FILE: audio/audio.c:260:
+static const char *audio_audfmt_to_string (AudioFormat fmt)

ERROR: space prohibited between function name and open parenthesis '('
#241: FILE: audio/audio.c:289:
+static AudioFormat audio_string_to_audfmt (const char *s, AudioFormat defval,

ERROR: space prohibited between function name and open parenthesis '('
#282: FILE: audio/audio.c:324:
+static AudioFormat audio_get_conf_fmt (const char *envname,

ERROR: space prohibited between function name and open parenthesis '('
#523: FILE: audio/ossaudio.c:151:
+static int aud_to_ossfmt (AudioFormat fmt, int endianness)

ERROR: space prohibited between function name and open parenthesis '('
#553: FILE: audio/ossaudio.c:185:
+static int oss_to_audfmt (int ossfmt, AudioFormat *fmt, int *endianness)

ERROR: space prohibited between function name and open parenthesis '('
#620: FILE: audio/paaudio.c:388:
+static pa_sample_format_t audfmt_to_pa (AudioFormat afmt, int endianness)

ERROR: space prohibited between function name and open parenthesis '('
#649: FILE: audio/paaudio.c:413:
+static AudioFormat pa_to_audfmt (pa_sample_format_t fmt, int *endianness)

ERROR: space prohibited between function name and open parenthesis '('
#687: FILE: audio/sdlaudio.c:140:
+static int aud_to_sdlfmt (AudioFormat fmt)

ERROR: trailing statements should be on next line
#954: FILE: hw/audio/hda-codec.c:102:
+    case AC_FMT_BITS_8:  as->fmt = AUDIO_FORMAT_S8;  break;

ERROR: trailing statements should be on next line
#955: FILE: hw/audio/hda-codec.c:103:
+    case AC_FMT_BITS_16: as->fmt = AUDIO_FORMAT_S16; break;

ERROR: trailing statements should be on next line
#956: FILE: hw/audio/hda-codec.c:104:
+    case AC_FMT_BITS_32: as->fmt = AUDIO_FORMAT_S32; break;

ERROR: space prohibited after that open square bracket '['
#970: FILE: hw/audio/hda-codec.c:137:
+    [ AUDIO_FORMAT_U8  ] = "PCM-U8",

ERROR: space prohibited before that close square bracket ']'
#970: FILE: hw/audio/hda-codec.c:137:
+    [ AUDIO_FORMAT_U8  ] = "PCM-U8",

ERROR: space prohibited after that open square bracket '['
#971: FILE: hw/audio/hda-codec.c:138:
+    [ AUDIO_FORMAT_S8  ] = "PCM-S8",

ERROR: space prohibited before that close square bracket ']'
#971: FILE: hw/audio/hda-codec.c:138:
+    [ AUDIO_FORMAT_S8  ] = "PCM-S8",

ERROR: space prohibited after that open square bracket '['
#972: FILE: hw/audio/hda-codec.c:139:
+    [ AUDIO_FORMAT_U16 ] = "PCM-U16",

ERROR: space prohibited before that close square bracket ']'
#972: FILE: hw/audio/hda-codec.c:139:
+    [ AUDIO_FORMAT_U16 ] = "PCM-U16",

ERROR: space prohibited after that open square bracket '['
#973: FILE: hw/audio/hda-codec.c:140:
+    [ AUDIO_FORMAT_S16 ] = "PCM-S16",

ERROR: space prohibited before that close square bracket ']'
#973: FILE: hw/audio/hda-codec.c:140:
+    [ AUDIO_FORMAT_S16 ] = "PCM-S16",

ERROR: space prohibited after that open square bracket '['
#974: FILE: hw/audio/hda-codec.c:141:
+    [ AUDIO_FORMAT_U32 ] = "PCM-U32",

ERROR: space prohibited before that close square bracket ']'
#974: FILE: hw/audio/hda-codec.c:141:
+    [ AUDIO_FORMAT_U32 ] = "PCM-U32",

ERROR: space prohibited after that open square bracket '['
#975: FILE: hw/audio/hda-codec.c:142:
+    [ AUDIO_FORMAT_S32 ] = "PCM-S32",

ERROR: space prohibited before that close square bracket ']'
#975: FILE: hw/audio/hda-codec.c:142:
+    [ AUDIO_FORMAT_S32 ] = "PCM-S32",

ERROR: trailing statements should be on next line
#1197: FILE: ui/vnc.c:2431:
+                case 0: vs->as.fmt = AUDIO_FORMAT_U8; break;

ERROR: trailing statements should be on next line
#1198: FILE: ui/vnc.c:2432:
+                case 1: vs->as.fmt = AUDIO_FORMAT_S8; break;

ERROR: trailing statements should be on next line
#1199: FILE: ui/vnc.c:2433:
+                case 2: vs->as.fmt = AUDIO_FORMAT_U16; break;

ERROR: trailing statements should be on next line
#1200: FILE: ui/vnc.c:2434:
+                case 3: vs->as.fmt = AUDIO_FORMAT_S16; break;

ERROR: trailing statements should be on next line
#1201: FILE: ui/vnc.c:2435:
+                case 4: vs->as.fmt = AUDIO_FORMAT_U32; break;

ERROR: trailing statements should be on next line
#1202: FILE: ui/vnc.c:2436:
+                case 5: vs->as.fmt = AUDIO_FORMAT_S32; break;

total: 31 errors, 0 warnings, 1028 lines checked

Patch 2/14 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

3/14 Checking commit 172a8519365e (audio: -audiodev command line option: 
documentation)
4/14 Checking commit 54e5804b4c2a (audio: -audiodev command line option basic 
implementation)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#937: 
new file mode 100644

total: 0 errors, 1 warnings, 1283 lines checked

Patch 4/14 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/14 Checking commit a2c88d6cd00e (alsaaudio: port to -audiodev config)
6/14 Checking commit 373893585072 (coreaudio: port to -audiodev config)
7/14 Checking commit 01d330b3a7f0 (dsoundaudio: port to -audiodev config)
8/14 Checking commit 96b7a11f8ee6 (noaudio: port to -audiodev config)
9/14 Checking commit eca548aefae2 (ossaudio: port to -audiodev config)
10/14 Checking commit a4cf2daf954f (paaudio: port to -audiodev config)
11/14 Checking commit 83031a0586cb (sdlaudio: port to -audiodev config)
12/14 Checking commit 53f2b3824652 (spiceaudio: port to -audiodev config)
13/14 Checking commit 2f7a6267e87e (wavaudio: port to -audiodev config)
14/14 Checking commit 9505d0ef8530 (audio: -audiodev command line option: 
cleanup)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden