Re: [Qemu-devel] [PATCH 0/2] Fix XHCI errors with isochronous transfer

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH 0/2] Fix XHCI errors with isochronous transfer
Type: series
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
e2d10359a8 usb: implement XHCI underrun/overrun events
2e60bc48ea usb: XHCI shall not halt isochronous endpoints

=== OUTPUT BEGIN ===
1/2 Checking commit 2e60bc48ea8c (usb: XHCI shall not halt isochronous 
endpoints)
2/2 Checking commit e2d10359a81c (usb: implement XHCI underrun/overrun events)
ERROR: spaces required around that '-' (ctx:VxV)
#36: FILE: hw/usb/hcd-xhci.c:1960:
+                xhci_event(xhci, &ev, xhci->slots[epctx->slotid-1].intr);
                                                                ^

ERROR: spaces required around that '-' (ctx:VxV)
#45: FILE: hw/usb/hcd-xhci.c:2041:
+    xhci->slots[slotid-1].intr = 0;
                       ^

ERROR: spaces required around that '-' (ctx:VxV)
#64: FILE: hw/usb/hcd-xhci.c:2316:
+        xhci->slots[slotid-1].intr = get_field(islot_ctx[2], TRB_INTR);
                           ^

ERROR: spaces required around that '-' (ctx:VxV)
#65: FILE: hw/usb/hcd-xhci.c:2317:
+        set_field(&slot_ctx[2], xhci->slots[slotid-1].intr, TRB_INTR);
                                                   ^

total: 4 errors, 0 warnings, 48 lines checked

Patch 2/2 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden