[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v13 30/31] block: BDS options may lack the "driver"
From: |
Max Reitz |
Subject: |
[Qemu-devel] [PATCH v13 30/31] block: BDS options may lack the "driver" option |
Date: |
Fri, 1 Feb 2019 20:29:34 +0100 |
When BDSs are created by qemu itself (e.g. as filters in block jobs),
they may not have a "driver" option in their options QDict. When
generating a json:{} filename, however, it must always be present.
Signed-off-by: Max Reitz <address@hidden>
Reviewed-by: Alberto Garcia <address@hidden>
---
block.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/block.c b/block.c
index c9a6cf0440..d496debda4 100644
--- a/block.c
+++ b/block.c
@@ -5557,6 +5557,12 @@ static bool append_strong_runtime_options(QDict *d,
BlockDriverState *bs)
}
}
+ if (!qdict_haskey(d, "driver")) {
+ /* Drivers created with bdrv_new_open_driver() may not have a
+ * @driver option. Add it here. */
+ qdict_put_str(d, "driver", bs->drv->format_name);
+ }
+
return found_any;
}
--
2.20.1
- [Qemu-devel] [PATCH v13 18/31] block/nfs: Implement bdrv_dirname(), (continued)
- [Qemu-devel] [PATCH v13 18/31] block/nfs: Implement bdrv_dirname(), Max Reitz, 2019/02/01
- [Qemu-devel] [PATCH v13 17/31] block/nbd: Make bdrv_dirname() return NULL, Max Reitz, 2019/02/01
- [Qemu-devel] [PATCH v13 19/31] block: Use bdrv_dirname() for relative filenames, Max Reitz, 2019/02/01
- [Qemu-devel] [PATCH v13 20/31] iotests: Add quorum case to test 110, Max Reitz, 2019/02/01
- [Qemu-devel] [PATCH v13 22/31] block: Add BlockDriver.bdrv_gather_child_options, Max Reitz, 2019/02/01
- [Qemu-devel] [PATCH v13 21/31] block: Add strong_runtime_opts to BlockDriver, Max Reitz, 2019/02/01
- [Qemu-devel] [PATCH v13 28/31] block/curl: Implement bdrv_refresh_filename(), Max Reitz, 2019/02/01
- [Qemu-devel] [PATCH v13 29/31] block/null: Generate filename even with latency-ns, Max Reitz, 2019/02/01
- [Qemu-devel] [PATCH v13 26/31] block/nvme: Fix bdrv_refresh_filename(), Max Reitz, 2019/02/01
- [Qemu-devel] [PATCH v13 25/31] block: Do not copy exact_filename from format file, Max Reitz, 2019/02/01
- [Qemu-devel] [PATCH v13 30/31] block: BDS options may lack the "driver" option,
Max Reitz <=
- [Qemu-devel] [PATCH v13 23/31] block: Generically refresh runtime options, Max Reitz, 2019/02/01
- [Qemu-devel] [PATCH v13 31/31] iotests: Test json:{} filenames of internal BDSs, Max Reitz, 2019/02/01
- [Qemu-devel] [PATCH v13 27/31] block/curl: Harmonize option defaults, Max Reitz, 2019/02/01
- [Qemu-devel] [PATCH v13 24/31] block: Purify .bdrv_refresh_filename(), Max Reitz, 2019/02/01
- Re: [Qemu-devel] [PATCH v13 00/31] Fix some filename generation issues, no-reply, 2019/02/03
- Re: [Qemu-devel] [PATCH v13 00/31] Fix some filename generation issues, Max Reitz, 2019/02/10