[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v11 2/3] qemu-img info lists bitmap directory en
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v11 2/3] qemu-img info lists bitmap directory entries |
Date: |
Mon, 4 Feb 2019 10:24:05 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 |
On 2/4/19 10:03 AM, Vladimir Sementsov-Ogievskiy wrote:
>>>> What would QMP clients do with this information?
>>>
>>> 'qemu-img info' is the intended QMP client; and it will print the
>>> unknown-flags along with everything else. In other words, we're trying
>>> to make qemu-img become useful for inspecting as much useful information
>>> as possible from an image with unknown origins. Knowing that an image
>>> uses bitmaps with flags unknown to THIS version of qemu is a good
>>> indication that you should be careful about using/altering the image
>>> without first upgrading qemu, as it may destroy data that some other
>>> product desires to utilize.
>>
>> Okay. Now work that into the documentation :)
>>
>
> I'll try:
>
> @unknown-flags: any flags except 'in-use' and 'auto' set for the bitmap.
> Presence of non-zero @unknown-flags definitely shows that
> image was created by newer version of software (which
> supports more bitmap flags) or corrupted. Image can't be
> used for r-w with non-zero @unknown-flags in any bitmap.
The grammar still feels awkward. Maybe:
@unknown-flags: If present, this is the value of additional bitmap flags
that were set in the image but not reported in @flags, implying that the
image was created with a newer version of software (that supports new
flags) or has been corrupted. Modifying the image without upgrading qemu
first will likely break the contents of the bitmap.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH v11 2/3] qemu-img info lists bitmap directory entries, Vladimir Sementsov-Ogievskiy, 2019/02/01
- Re: [Qemu-devel] [PATCH v11 2/3] qemu-img info lists bitmap directory entries, Eric Blake, 2019/02/01
- Re: [Qemu-devel] [PATCH v11 2/3] qemu-img info lists bitmap directory entries, Kevin Wolf, 2019/02/01
- Re: [Qemu-devel] [PATCH v11 2/3] qemu-img info lists bitmap directory entries, Markus Armbruster, 2019/02/01
- Re: [Qemu-devel] [PATCH v11 2/3] qemu-img info lists bitmap directory entries, Eric Blake, 2019/02/01
- Re: [Qemu-devel] [PATCH v11 2/3] qemu-img info lists bitmap directory entries, Markus Armbruster, 2019/02/01
- Re: [Qemu-devel] [PATCH v11 2/3] qemu-img info lists bitmap directory entries, Eric Blake, 2019/02/01
- Re: [Qemu-devel] [PATCH v11 2/3] qemu-img info lists bitmap directory entries, Markus Armbruster, 2019/02/04
- Re: [Qemu-devel] [PATCH v11 2/3] qemu-img info lists bitmap directory entries, Vladimir Sementsov-Ogievskiy, 2019/02/04
- Re: [Qemu-devel] [PATCH v11 2/3] qemu-img info lists bitmap directory entries,
Eric Blake <=
- Re: [Qemu-devel] [PATCH v11 2/3] qemu-img info lists bitmap directory entries, Vladimir Sementsov-Ogievskiy, 2019/02/04
- Re: [Qemu-devel] [PATCH v11 2/3] qemu-img info lists bitmap directory entries, Vladimir Sementsov-Ogievskiy, 2019/02/04
- Re: [Qemu-devel] [PATCH v11 2/3] qemu-img info lists bitmap directory entries, Eric Blake, 2019/02/04
- Re: [Qemu-devel] [PATCH v11 2/3] qemu-img info lists bitmap directory entries, Eric Blake, 2019/02/04
Re: [Qemu-devel] [PATCH v11 2/3] qemu-img info lists bitmap directory entries, Vladimir Sementsov-Ogievskiy, 2019/02/04
Re: [Qemu-devel] [PATCH v11 2/3] qemu-img info lists bitmap directory entries, Kevin Wolf, 2019/02/04