[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 0/8] NBD patches for 2019-02-04
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PULL 0/8] NBD patches for 2019-02-04 |
Date: |
Mon, 4 Feb 2019 22:12:03 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 |
On 2/4/19 10:08 PM, address@hidden wrote:
> Patchew URL: https://patchew.org/QEMU/address@hidden/
>
>
>
> Hi,
>
> This series seems to have some coding style problems. See output below for
> more information:
>
> 2/8 Checking commit bd906b01ffe8 (nbd: generalize usage of nbd_read)
> ERROR: spaces required around that '*' (ctx:WxV)
> #85: FILE: include/block/nbd.h:356:
> + uint##bits##_t *val, \
> ^
>
> total: 1 errors, 0 warnings, 386 lines checked
>
> Patch 2/8 has style problems, please review. If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
False positive. Seeing past ## pasting in a macro is not trivial to fix
in checkpatch, so I'm intentionally ignoring this one.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PULL 0/8] NBD patches for 2019-02-04, Eric Blake, 2019/02/04
- [Qemu-devel] [PULL 1/8] qemu-nbd: Deprecate qemu-nbd --partition, Eric Blake, 2019/02/04
- [Qemu-devel] [PULL 2/8] nbd: generalize usage of nbd_read, Eric Blake, 2019/02/04
- [Qemu-devel] [PULL 4/8] block/nbd: move connection code from block/nbd to block/nbd-client, Eric Blake, 2019/02/04
- [Qemu-devel] [PULL 6/8] block/nbd-client: fix nbd_reply_chunk_iter_receive, Eric Blake, 2019/02/04
- [Qemu-devel] [PULL 5/8] block/nbd-client: split connection from initialization, Eric Blake, 2019/02/04
- [Qemu-devel] [PULL 3/8] block/nbd-client: split channel errors from export errors, Eric Blake, 2019/02/04
- [Qemu-devel] [PULL 7/8] block/nbd-client: don't check ioc, Eric Blake, 2019/02/04
- [Qemu-devel] [PULL 8/8] block/nbd-client: rename read_reply_co to connection_co, Eric Blake, 2019/02/04
- Re: [Qemu-devel] [PULL 0/8] NBD patches for 2019-02-04, no-reply, 2019/02/04
- Re: [Qemu-devel] [PULL 0/8] NBD patches for 2019-02-04,
Eric Blake <=
- Re: [Qemu-devel] [PULL 0/8] NBD patches for 2019-02-04, no-reply, 2019/02/04
- Re: [Qemu-devel] [PULL 0/8] NBD patches for 2019-02-04, no-reply, 2019/02/05
- Re: [Qemu-devel] [PULL 0/8] NBD patches for 2019-02-04, Peter Maydell, 2019/02/05