[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 0/2] block/ssh: Implement .bdrv_refresh_filen
From: |
Richard W.M. Jones |
Subject: |
Re: [Qemu-devel] [PATCH v2 0/2] block/ssh: Implement .bdrv_refresh_filename() |
Date: |
Wed, 6 Feb 2019 16:37:04 +0000 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, Feb 06, 2019 at 04:29:17PM +0100, Max Reitz wrote:
> This series implements .bdrv_refresh_filename() for the ssh block
> driver, along with an appropriate .bdrv_dirname() so we don't chop off
> query strings for backing files with relative filenames.
>
> This series depends on my "block: Fix some filename generation issues"
> series.
>
> Based-on: address@hidden
I have verified that this doesn't appear to break the existing driver:
ssh connections to block devices still work as well as they did before
(which is to say, not very well, I wish we would replace this driver
with Pino Toscano's reimplementation that uses libssh1).
However I wasn't sure how I could trigger the bdrv_refresh_filename
code path, so I don't think I tested that.
Rich.
>
> v2:
> - No longer based on the libssh2 -> libssh patches
> - Put /* and */ on their own lines to make checkpatch happy
>
>
> Max Reitz (2):
> block/ssh: Implement .bdrv_refresh_filename()
> block/ssh: Implement .bdrv_dirname()
>
> block/ssh.c | 73 +++++++++++++++++++++++++++++++++++++++++++++++++----
> 1 file changed, 68 insertions(+), 5 deletions(-)
>
> --
> 2.20.1
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-p2v converts physical machines to virtual machines. Boot with a
live CD or over the network (PXE) and turn machines into KVM guests.
http://libguestfs.org/virt-v2v