[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 16/18] chardev: ensure termios is fully initialized
From: |
Marc-André Lureau |
Subject: |
[Qemu-devel] [PULL 16/18] chardev: ensure termios is fully initialized |
Date: |
Thu, 7 Feb 2019 17:06:15 +0100 |
From: Daniel P. Berrangé <address@hidden>
valgrind on the test-char.c code reports that 'struct termios' contains
uninitialized memory.
Signed-off-by: Daniel P. Berrangé <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>
---
chardev/char-serial.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/chardev/char-serial.c b/chardev/char-serial.c
index 3299b46853..a8bae31b8d 100644
--- a/chardev/char-serial.c
+++ b/chardev/char-serial.c
@@ -57,7 +57,7 @@ static void qmp_chardev_open_serial(Chardev *chr,
static void tty_serial_init(int fd, int speed,
int parity, int data_bits, int stop_bits)
{
- struct termios tty;
+ struct termios tty = {0};
speed_t spd;
#if 0
--
2.20.1.519.g8feddda32c
- [Qemu-devel] [PULL 09/18] chardev: split tcp_chr_wait_connected into two methods, (continued)
- [Qemu-devel] [PULL 09/18] chardev: split tcp_chr_wait_connected into two methods, Marc-André Lureau, 2019/02/07
- [Qemu-devel] [PULL 10/18] chardev: split up qmp_chardev_open_socket connection code, Marc-André Lureau, 2019/02/07
- [Qemu-devel] [PULL 05/18] chardev: forbid 'wait' option with client sockets, Marc-André Lureau, 2019/02/07
- [Qemu-devel] [PULL 02/18] io: add qio_task_wait_thread to join with a background thread, Marc-André Lureau, 2019/02/07
- [Qemu-devel] [PULL 08/18] chardev: remove unused 'sioc' variable & cleanup paths, Marc-André Lureau, 2019/02/07
- [Qemu-devel] [PULL 01/18] io: store reference to thread information in the QIOTask struct, Marc-André Lureau, 2019/02/07
- [Qemu-devel] [PULL 11/18] chardev: use a state machine for socket connection state, Marc-André Lureau, 2019/02/07
- [Qemu-devel] [PULL 12/18] chardev: honour the reconnect setting in tcp_chr_wait_connected, Marc-André Lureau, 2019/02/07
- [Qemu-devel] [PULL 13/18] chardev: disallow TLS/telnet/websocket with tcp_chr_wait_connected, Marc-André Lureau, 2019/02/07
- [Qemu-devel] [PULL 14/18] chardev: fix race with client connections in tcp_chr_wait_connected, Marc-André Lureau, 2019/02/07
- [Qemu-devel] [PULL 16/18] chardev: ensure termios is fully initialized,
Marc-André Lureau <=
- [Qemu-devel] [PULL 18/18] tests/test-char: add muxed chardev testing for open/close, Marc-André Lureau, 2019/02/07
- [Qemu-devel] [PULL 17/18] chardev: fix mess in OPENED/CLOSED events when muxed, Marc-André Lureau, 2019/02/07
- [Qemu-devel] [PULL 15/18] tests: expand coverage of socket chardev test, Marc-André Lureau, 2019/02/07
- Re: [Qemu-devel] [PULL 00/18] Chardev patches, Peter Maydell, 2019/02/08
- Re: [Qemu-devel] [PULL 00/18] Chardev patches, Daniel P . Berrangé, 2019/02/11