[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] Maintainers, please git-am -m
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] Maintainers, please git-am -m |
Date: |
Fri, 8 Feb 2019 11:34:19 +0100 |
User-agent: |
NeoMutt/20180716 |
On Fri, Feb 08, 2019 at 09:57:20AM +0100, Cornelia Huck wrote:
> On Fri, 08 Feb 2019 08:30:11 +0100
> Markus Armbruster <address@hidden> wrote:
>
> > Short story: please add
> >
> > [am]
> > messageid = true
> >
> > to your .gitconfig.
> >
> > Long story. git-am can add a Message-id: tag. Looks like this:
> >
> > commit 335dbb5de1e98c4dc73590349f17bb2a4d72596c
> > Author: Thomas Huth <address@hidden>
> > Date: Mon Feb 4 09:25:43 2019 +0100
> > Commit: Peter Maydell <address@hidden>
> > CommitDate: Mon Feb 4 15:25:21 2019 +0000
> >
> > tests/docker/test-mingw and docs: Remove --with-sdlabi=2.0
> >
> > Patchew currently reports failures with the mingw docker test - this
> > is due to --with-sdlabi=2.0 configure flag which does not exist
> > anymore.
> > Remove this remainder from the docker test and the docs now.
> >
> > Signed-off-by: Thomas Huth <address@hidden>
> > Reviewed-by: Daniel P. Berrangé <address@hidden>
> > Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> > Tested-by: Philippe Mathieu-Daudé <address@hidden>
> > Acked-by: Alex Bennée <address@hidden>
> > ---> Message-id: address@hidden
> > Signed-off-by: Peter Maydell <address@hidden>
> >
> > The Message-id identifies the patch e-mail. It makes finding the review
> > thread easier and more reliable. It's also a valid key on Patchew[*].
>
> I'm using it for anything I git am, but I'm usually not git am'ing my
> own patches (I just merge from the branch I have them on). Is the
> message id valuable enough to warrant the extra round-trip for patches
> that are committed by the authors themselves?
I typically do that, using Stefan's "patches" tool, to automatically
collect Reviewed-by: lines from replies. And that adds the message id
too.
cheers,
Gerd
- [Qemu-devel] Maintainers, please git-am -m, Markus Armbruster, 2019/02/08
- Re: [Qemu-devel] Maintainers, please git-am -m, Thomas Huth, 2019/02/08
- Re: [Qemu-devel] Maintainers, please git-am -m, Cornelia Huck, 2019/02/08
- Re: [Qemu-devel] Maintainers, please git-am -m,
Gerd Hoffmann <=
- Re: [Qemu-devel] Maintainers, please git-am -m, Philippe Mathieu-Daudé, 2019/02/08
- Re: [Qemu-devel] Maintainers, please git-am -m, Eric Blake, 2019/02/25