[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] configure: Make -Waddress-of-packed-member warn
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [PATCH] configure: Make -Waddress-of-packed-member warnings be errors |
Date: |
Fri, 8 Feb 2019 16:21:38 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 |
On 2/8/19 2:21 PM, Peter Maydell wrote:
> We have now managed to eradicate all the places in the codebase
> that triggered clang's -Waddress-of-packed-member warning. Remove
> the compiler flag that exempted it from our usual -Werror policy.
> This will prevent any new problematic code being added in future.
Yay!
>
> Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> configure | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/configure b/configure
> index fbd0825488c..50ac5d90f2e 100755
> --- a/configure
> +++ b/configure
> @@ -1881,7 +1881,6 @@ gcc_flags="-Wno-missing-include-dirs -Wempty-body
> -Wnested-externs $gcc_flags"
> gcc_flags="-Wendif-labels -Wno-shift-negative-value $gcc_flags"
> gcc_flags="-Wno-initializer-overrides -Wexpansion-to-defined $gcc_flags"
> gcc_flags="-Wno-string-plus-int $gcc_flags"
> -gcc_flags="-Wno-error=address-of-packed-member $gcc_flags"
> # Note that we do not add -Werror to gcc_flags here, because that would
> # enable it for all configure tests. If a configure test failed due
> # to -Werror this would just silently disable some features,
>