[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 2/3] tpm_tis: assert valid addr passed to tpm_tis
From: |
Liam Merwick |
Subject: |
[Qemu-devel] [PATCH v2 2/3] tpm_tis: assert valid addr passed to tpm_tis_locality_from_addr() |
Date: |
Mon, 11 Feb 2019 15:03:04 +0000 |
Defensive check to prevent future caller passing incorrect address
or catch if the MMIO address parameters were not all changed together.
Signed-off-by: Liam Merwick <address@hidden>
---
I've been running static analysis tools on QEMU and one reports this check.
While it's just theoretically correct (impossible to hit with current code),
fixing this helps minimise noise and find other issues using those static
analyzers as well as defending against the addition of future bugs.
hw/tpm/tpm_tis.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/tpm/tpm_tis.c b/hw/tpm/tpm_tis.c
index 61a130beef35..860c2ace7d99 100644
--- a/hw/tpm/tpm_tis.c
+++ b/hw/tpm/tpm_tis.c
@@ -100,6 +100,7 @@ static uint64_t tpm_tis_mmio_read(void *opaque, hwaddr addr,
static uint8_t tpm_tis_locality_from_addr(hwaddr addr)
{
+ assert(addr < TPM_TIS_ADDR_SIZE);
return (uint8_t)((addr >> TPM_TIS_LOCALITY_SHIFT) & 0x7);
}
--
1.8.3.1
- [Qemu-devel] [PATCH v2 3/3] tpm_tis: fix format string specifier in tpm_tis_show_buffer(), (continued)
- [Qemu-devel] [PATCH v2 3/3] tpm_tis: fix format string specifier in tpm_tis_show_buffer(), Liam Merwick, 2019/02/11
- Re: [Qemu-devel] [PATCH v2 3/3] tpm_tis: fix format string specifier in tpm_tis_show_buffer(), Philippe Mathieu-Daudé, 2019/02/11
- Re: [Qemu-devel] [PATCH v2 3/3] tpm_tis: fix format string specifier in tpm_tis_show_buffer(), Stefan Berger, 2019/02/11
- Re: [Qemu-devel] [PATCH v2 3/3] tpm_tis: fix format string specifier in tpm_tis_show_buffer(), Liam Merwick, 2019/02/11
- Re: [Qemu-devel] [PATCH v2 3/3] tpm_tis: fix format string specifier in tpm_tis_show_buffer(), Stefan Berger, 2019/02/11
- Re: [Qemu-devel] [PATCH v2 3/3] tpm_tis: fix format string specifier in tpm_tis_show_buffer(), Philippe Mathieu-Daudé, 2019/02/12
- Re: [Qemu-devel] [PATCH v2 3/3] tpm_tis: fix format string specifier in tpm_tis_show_buffer(), Stefan Berger, 2019/02/12
- Re: [Qemu-devel] [PATCH v2 3/3] tpm_tis: fix format string specifier in tpm_tis_show_buffer(), Liam Merwick, 2019/02/12
- Re: [Qemu-devel] [PATCH v2 3/3] tpm_tis: fix format string specifier in tpm_tis_show_buffer(), Philippe Mathieu-Daudé, 2019/02/12
Re: [Qemu-devel] [PATCH v2 3/3] tpm_tis: fix format string specifier in tpm_tis_show_buffer(), Stefan Berger, 2019/02/12
[Qemu-devel] [PATCH v2 2/3] tpm_tis: assert valid addr passed to tpm_tis_locality_from_addr(),
Liam Merwick <=
Re: [Qemu-devel] [PATCH v2 1/3] tpm_tis: fix loop that cancels any seizure by a lower locality, Stefan Berger, 2019/02/11