[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 04/15] s390x/tcg: Fix parts of IEEE exception
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH v1 04/15] s390x/tcg: Fix parts of IEEE exception handling |
Date: |
Tue, 12 Feb 2019 10:13:07 -0800 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 |
On 2/12/19 3:02 AM, David Hildenbrand wrote:
> Many things are wrong and some parts cannot be fixed yet. Fix what we
> can fix easily and add two FIXMEs:
>
> The fpc flags are not updated in case an exception is actually injected.
> Inexact exceptions have to be handled separately, as they are the only
> exceptions that can coexist with underflows and overflows.
>
> I reread the horribly complicated chapters in the PoP at least 5 times
> and hope I got it right.
>
> For references:
> - z14 PoP, 9-18, "IEEE Exceptions"
> - z14 PoP, 19-9, Figure 19-8
>
> Signed-off-by: David Hildenbrand <address@hidden>
> ---
> target/s390x/fpu_helper.c | 38 ++++++++++++++++++++++++++++++++------
> 1 file changed, 32 insertions(+), 6 deletions(-)
Reviewed-by: Richard Henderson <address@hidden>
r~
- [Qemu-devel] [PATCH v1] s390x: Add floating-point extension facility to "qemu" cpu model, David Hildenbrand, 2019/02/12
- [Qemu-devel] [PATCH v1 00/15] s390x/tcg: Implement floating-point extension facility, David Hildenbrand, 2019/02/12
- [Qemu-devel] [PATCH v1 06/15] s390x/tcg: Refactor SET FPC AND SIGNAL handling, David Hildenbrand, 2019/02/12
- [Qemu-devel] [PATCH v1 04/15] s390x/tcg: Fix parts of IEEE exception handling, David Hildenbrand, 2019/02/12
- Re: [Qemu-devel] [PATCH v1 04/15] s390x/tcg: Fix parts of IEEE exception handling,
Richard Henderson <=
- [Qemu-devel] [PATCH v1 02/15] s390x/tcg: Fix rounding from float128 to uint64_t/uin32_t, David Hildenbrand, 2019/02/12
- [Qemu-devel] [PATCH v1 09/15] s390x/tcg: Check for exceptions in SET BFP ROUNDING MODE, David Hildenbrand, 2019/02/12
- [Qemu-devel] [PATCH v1 01/15] s390x/tcg: Fix TEST DATA CLASS instructions, David Hildenbrand, 2019/02/12
- [Qemu-devel] [PATCH v1 05/15] s390x/tcg: Hide IEEE underflows in some scenarios, David Hildenbrand, 2019/02/12
- [Qemu-devel] [PATCH v1 03/15] s390x/tcg: Factor out conversion of softfloat exceptions, David Hildenbrand, 2019/02/12