[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] hostmem-file: reject invalid pmem file sizes
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH] hostmem-file: reject invalid pmem file sizes |
Date: |
Wed, 13 Feb 2019 15:01:12 +0800 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On Tue, Feb 12, 2019 at 03:44:46PM +0100, Igor Mammedov wrote:
> > diff --git a/backends/hostmem-file.c b/backends/hostmem-file.c
> > index ba601ce940..325ab4aad9 100644
> > --- a/backends/hostmem-file.c
> > +++ b/backends/hostmem-file.c
> > @@ -46,6 +46,22 @@ file_backend_memory_alloc(HostMemoryBackend *backend,
> > Error **errp)
> > gchar *name;
> > #endif
> >
> > + /*
> > + * Verify pmem file size since starting a guest with an incorrect size
> > + * leads to confusing failures inside the guest.
> > + */
> > + if (fb->is_pmem && fb->mem_path) {
> > + uint64_t size;
> > +
> > + size = qemu_get_pmem_size(fb->mem_path, NULL);
> ^^^^
> Did you ignore error intentionally?
Hmm...I think I can now propagate the error. Originally the function
only handled devdax chardevs so it would fail for a regular file on a
DAX file system and that shouldn't stop QEMU startup. But now that it
supports regular files too I can't think of inputs that lead to a false
positive.
Will fix in v2.
Stefan
signature.asc
Description: PGP signature