[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 00/18] qapi: add #if pre-processor conditions
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v5 00/18] qapi: add #if pre-processor conditions to generated code (part 3) |
Date: |
Thu, 14 Feb 2019 10:01:55 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 |
On 2/14/19 9:24 AM, Markus Armbruster wrote:
> Diff from v4:
>
> +++ b/qapi/Makefile.objs
> @@ -18,8 +18,9 @@ util-obj-y += $(QAPI_COMMON_MODULES:%=qapi-visit-%.o)
> util-obj-y += qapi-emit-events.o
> util-obj-y += $(QAPI_COMMON_MODULES:%=qapi-events-%.o)
>
> -common-obj-y += $(QAPI_COMMON_MODULES:%=qapi-commands-%.o)
> +common-obj-y = $(QAPI_COMMON_MODULES:%=qapi-commands-%.o)
In other situations, use of = instead of += has resulted in inadvertent
omission of files. Should we just always use +=, rather than having to
remember to audit if the use of = is not overriding earlier lines?
>
> +obj-y = qapi-introspect.o
and again
> obj-y += $(QAPI_TARGET_MODULES:%=qapi-types-%.o)
> obj-y += qapi-types.o
> obj-y += $(QAPI_TARGET_MODULES:%=qapi-visit-%.o)
> @@ -28,4 +29,3 @@ obj-y += $(QAPI_TARGET_MODULES:%=qapi-events-%.o)
> obj-y += qapi-events.o
> obj-y += $(QAPI_TARGET_MODULES:%=qapi-commands-%.o)
> obj-y += qapi-commands.o
> -obj-y += qapi-introspect.o
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v5 01/18] qapi: Belatedly document modular code generation, (continued)
- [Qemu-devel] [PATCH v5 01/18] qapi: Belatedly document modular code generation, Markus Armbruster, 2019/02/14
- [Qemu-devel] [PATCH v5 10/18] qapi: make s390 commands depend on TARGET_S390X, Markus Armbruster, 2019/02/14
- [Qemu-devel] [PATCH v5 13/18] qapi: make query-cpu-model-expansion depend on s390 or x86, Markus Armbruster, 2019/02/14
- [Qemu-devel] [PATCH v5 05/18] qapi: Generate QAPIEvent stuff into separate files, Markus Armbruster, 2019/02/14
- [Qemu-devel] [PATCH v5 12/18] qapi: make query-gic-capabilities depend on TARGET_ARM, Markus Armbruster, 2019/02/14
- [Qemu-devel] [PATCH v5 17/18] qmp: Deprecate query-events in favor of query-qmp-schema, Markus Armbruster, 2019/02/14
- [Qemu-devel] [PATCH v5 14/18] qapi: make query-cpu-definitions depend on specific targets, Markus Armbruster, 2019/02/14
- [Qemu-devel] [PATCH v5 18/18] qapi: move RTC_CHANGE to the target schema, Markus Armbruster, 2019/02/14
- [Qemu-devel] [PATCH v5 02/18] qapi: Fix up documentation for recent commit a95291007b2, Markus Armbruster, 2019/02/14
- Re: [Qemu-devel] [PATCH v5 00/18] qapi: add #if pre-processor conditions to generated code (part 3), Markus Armbruster, 2019/02/14
- Re: [Qemu-devel] [PATCH v5 00/18] qapi: add #if pre-processor conditions to generated code (part 3),
Eric Blake <=