[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC] memory: use memory_region_init_ram() instead of m
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [RFC] memory: use memory_region_init_ram() instead of memory_region_allocate_system_memory() |
Date: |
Thu, 14 Feb 2019 18:30:37 +0000 |
On Thu, 14 Feb 2019 at 14:07, Igor Mammedov <address@hidden> wrote:
> Also some boards (ab)use memory_region_allocate_system_memory(), calling it
> several
> times to allocate various fixed sized chunks of RAM and ROMs, which is
> problematic
> to map to a single initial RAM Machine::memdev backend and is currently
> broken if
> -mem-path points to a not hugepage pool.
These boards are buggy and we could fix them, if we wanted to
keep the existing API. We should in that case add assertions
that memory_region_allocate_system_memory() is called once and
only once, which would let "make check" enforce the rule.
thanks
- PMM
Re: [Qemu-devel] [RFC] memory: use memory_region_init_ram() instead of memory_region_allocate_system_memory(),
Peter Maydell <=