[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH] migration/rdma: Fix qemu_rdma_cleanup null check
From: |
Dr. David Alan Gilbert (git) |
Subject: |
[Qemu-devel] [PATCH] migration/rdma: Fix qemu_rdma_cleanup null check |
Date: |
Thu, 14 Feb 2019 18:53:51 +0000 |
From: "Dr. David Alan Gilbert" <address@hidden>
If the migration fails before the channel is open (e.g. a bad
address) we end up in the cleanup with rdma->channel==NULL.
Spotted by Coverity: CID 1398634
Fixes: fbbaacab2758cb3f32a0
Signed-off-by: Dr. David Alan Gilbert <address@hidden>
---
migration/rdma.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/migration/rdma.c b/migration/rdma.c
index 54a3c11540..9fa3b176eb 100644
--- a/migration/rdma.c
+++ b/migration/rdma.c
@@ -2321,7 +2321,9 @@ static void qemu_rdma_cleanup(RDMAContext *rdma)
rdma->connected = false;
}
- qemu_set_fd_handler(rdma->channel->fd, NULL, NULL, NULL);
+ if (rdma->channel) {
+ qemu_set_fd_handler(rdma->channel->fd, NULL, NULL, NULL);
+ }
g_free(rdma->dest_blocks);
rdma->dest_blocks = NULL;
--
2.20.1
- [Qemu-devel] [PATCH] migration/rdma: Fix qemu_rdma_cleanup null check,
Dr. David Alan Gilbert (git) <=