[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 27/27] gdbstub: Send a reply to the vKill packet.
From: |
Peter Maydell |
Subject: |
[Qemu-devel] [PULL 27/27] gdbstub: Send a reply to the vKill packet. |
Date: |
Thu, 14 Feb 2019 19:06:03 +0000 |
From: Sandra Loosemore <address@hidden>
Per the GDB remote protocol documentation
https://sourceware.org/gdb/current/onlinedocs/gdb/Packets.html#index-vKill-packet
the debug stub is expected to send a reply to the 'vKill' packet. At
least some versions of GDB crash if the gdb stub simply exits without
sending a reply. This patch fixes QEMU's gdb stub to conform to the
expected behavior.
Note that QEMU's existing handling of the legacy 'k' packet is
correct: in that case GDB does not expect a reply, and QEMU does not
send one.
Signed-off-by: Sandra Loosemore <address@hidden>
Message-id: address@hidden
Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Peter Maydell <address@hidden>
---
gdbstub.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/gdbstub.c b/gdbstub.c
index ff19579452d..bc774ae9925 100644
--- a/gdbstub.c
+++ b/gdbstub.c
@@ -1361,6 +1361,7 @@ static int gdb_handle_packet(GDBState *s, const char
*line_buf)
break;
} else if (strncmp(p, "Kill;", 5) == 0) {
/* Kill the target */
+ put_packet(s, "OK");
error_report("QEMU: Terminated via GDBstub");
exit(0);
} else {
--
2.20.1
- [Qemu-devel] [PULL 14/27] hw/arm/armsse: Fix miswiring of expansion IRQs, (continued)
- [Qemu-devel] [PULL 14/27] hw/arm/armsse: Fix miswiring of expansion IRQs, Peter Maydell, 2019/02/14
- [Qemu-devel] [PULL 13/27] hw/intc/armv7m_nvic: Allow byte accesses to SHPR1, Peter Maydell, 2019/02/14
- [Qemu-devel] [PULL 11/27] arm: Allow system registers for KVM guests to be changed by QEMU code, Peter Maydell, 2019/02/14
- [Qemu-devel] [PULL 22/27] target/arm: Split out flags setting from vfp compares, Peter Maydell, 2019/02/14
- [Qemu-devel] [PULL 18/27] target/arm: Use tcg integer min/max primitives for neon, Peter Maydell, 2019/02/14
- [Qemu-devel] [PULL 23/27] target/arm: Fix set of bits kept in xregs[ARM_VFP_FPSCR], Peter Maydell, 2019/02/14
- [Qemu-devel] [PULL 17/27] target/arm: Use vector minmax expanders for aarch32, Peter Maydell, 2019/02/14
- [Qemu-devel] [PULL 21/27] target/arm: Fix arm_cpu_dump_state vs FPSCR, Peter Maydell, 2019/02/14
- [Qemu-devel] [PULL 20/27] target/arm: Fix vfp_gdb_get/set_reg vs FPSCR, Peter Maydell, 2019/02/14
- [Qemu-devel] [PULL 16/27] target/arm: Use vector minmax expanders for aarch64, Peter Maydell, 2019/02/14
- [Qemu-devel] [PULL 27/27] gdbstub: Send a reply to the vKill packet.,
Peter Maydell <=
- [Qemu-devel] [PULL 25/27] target/arm: Use vector operations for saturation, Peter Maydell, 2019/02/14
- [Qemu-devel] [PULL 26/27] target/arm: Add missing clear_tail calls, Peter Maydell, 2019/02/14
- [Qemu-devel] [PULL 24/27] target/arm: Split out FPSCR.QC to a vector field, Peter Maydell, 2019/02/14
- Re: [Qemu-devel] [PULL 00/27] target-arm queue, no-reply, 2019/02/14
- Re: [Qemu-devel] [PULL 00/27] target-arm queue, no-reply, 2019/02/14
- Re: [Qemu-devel] [PULL 00/27] target-arm queue, no-reply, 2019/02/14
- Re: [Qemu-devel] [PULL 00/27] target-arm queue, no-reply, 2019/02/14
- Re: [Qemu-devel] [PULL 00/27] target-arm queue, no-reply, 2019/02/14
- Re: [Qemu-devel] [PULL 00/27] target-arm queue, no-reply, 2019/02/14
- Re: [Qemu-devel] [PULL 00/27] target-arm queue, no-reply, 2019/02/14