[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 3/9] ccid-card-passthru: Assert on a stricter
From: |
Wei Yang |
Subject: |
Re: [Qemu-devel] [PATCH v2 3/9] ccid-card-passthru: Assert on a stricter expression |
Date: |
Fri, 15 Feb 2019 16:47:19 +0800 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
Would it be better to have some description?
On Thu, Feb 14, 2019 at 09:19:33PM +0100, Philippe Mathieu-Daudé wrote:
>Suggested-by: Paolo Bonzini <address@hidden>
>Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
>---
> hw/usb/ccid-card-passthru.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/hw/usb/ccid-card-passthru.c b/hw/usb/ccid-card-passthru.c
>index 1676b5fc05..0c44b38fc2 100644
>--- a/hw/usb/ccid-card-passthru.c
>+++ b/hw/usb/ccid-card-passthru.c
>@@ -270,7 +270,7 @@ static void ccid_card_vscard_read(void *opaque, const
>uint8_t *buf, int size)
> VSCMsgHeader *hdr;
>
> assert(size <= VSCARD_IN_SIZE - card->vscard_in_pos);
>- assert(card->vscard_in_hdr < VSCARD_IN_SIZE);
>+ assert(card->vscard_in_hdr < card->vscard_in_pos);
> memcpy(card->vscard_in_data + card->vscard_in_pos, buf, size);
> card->vscard_in_pos += size;
> hdr = (VSCMsgHeader *)(card->vscard_in_data + card->vscard_in_hdr);
>--
>2.20.1
>
--
Wei Yang
Help you, Help me
- [Qemu-devel] [PATCH v2 0/9] ccid-card-passthru: check buffer size parameter, Philippe Mathieu-Daudé, 2019/02/14
- [Qemu-devel] [PATCH v2 1/9] ccid-card-passthru: Move assertion in read() to can_read(), Philippe Mathieu-Daudé, 2019/02/14
- [Qemu-devel] [PATCH v2 2/9] ccid-card-passthru: Replace never trigger if statement by an assertion, Philippe Mathieu-Daudé, 2019/02/14
- [Qemu-devel] [PATCH v2 3/9] ccid-card-passthru: Assert on a stricter expression, Philippe Mathieu-Daudé, 2019/02/14
- [Qemu-devel] [PATCH v2 4/9] ccid-card-passthru: Let the chardev::read() be more generic, Philippe Mathieu-Daudé, 2019/02/14
- [Qemu-devel] [PATCH v2 5/9] ccid-card-passthru: Replace assert() by QEMU_BUILD_BUG_ON(), Philippe Mathieu-Daudé, 2019/02/14
- [Qemu-devel] [PATCH v2 7/9] ccid-card-passthru: Use QERR_MISSING_PARAMETER, Philippe Mathieu-Daudé, 2019/02/14
- [Qemu-devel] [PATCH v2 6/9] ccid-card-passthru: Simplify the if() condition, Philippe Mathieu-Daudé, 2019/02/14
- [Qemu-devel] [PATCH v2 9/9] ccid-card-passthru: Use size_t for index, Philippe Mathieu-Daudé, 2019/02/14