[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 02/14] hw/misc/tz-ppc: Support having unused por
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH 02/14] hw/misc/tz-ppc: Support having unused ports in the middle of the range |
Date: |
Sun, 17 Feb 2019 09:51:59 -0800 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 |
On 2/14/19 4:50 AM, Peter Maydell wrote:
> The Peripheral Protection Controller's handling of unused ports
> is that if there is nothing connected to the port's downstream
> then it does not create the sysbus MMIO region for the upstream
> end of the port. This results in odd behaviour when there is
> an unused port in the middle of the range: since sysbus MMIO
> regions are implicitly consecutively allocated, any used ports
> above the unused ones end up with sysbus MMIO region numbers
> that don't match the port number.
>
> Avoid this numbering mismatch by creating dummy MMIO regions
> for the unused ports. This doesn't change anything for our
> existing boards, which don't have any gaps in the middle of
> the port ranges they use; but it will be needed for the Musca
> board.
>
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> include/hw/misc/tz-ppc.h | 8 +++++++-
> hw/misc/tz-ppc.c | 32 ++++++++++++++++++++++++++++++++
> 2 files changed, 39 insertions(+), 1 deletion(-)
Reviewed-by: Richard Henderson <address@hidden>
r~
- Re: [Qemu-devel] [PATCH 09/14] hw/arm/armsse: Allow boards to specify init-svtor, (continued)
- [Qemu-devel] [PATCH 10/14] hw/arm/musca.c: Implement models of the Musca-A and -B1 boards, Peter Maydell, 2019/02/14
- [Qemu-devel] [PATCH 08/14] hw/arm/armsse: Document SRAM_ADDR_WIDTH property in header comment, Peter Maydell, 2019/02/14
- [Qemu-devel] [PATCH 03/14] hw/timer/pl031: Allow use as an embedded-struct device, Peter Maydell, 2019/02/14
- [Qemu-devel] [PATCH 02/14] hw/misc/tz-ppc: Support having unused ports in the middle of the range, Peter Maydell, 2019/02/14
- Re: [Qemu-devel] [PATCH 02/14] hw/misc/tz-ppc: Support having unused ports in the middle of the range,
Richard Henderson <=
- [Qemu-devel] [PATCH 05/14] hw/char/pl011: Allow use as an embedded-struct device, Peter Maydell, 2019/02/14
- [Qemu-devel] [PATCH 13/14] hw/arm/musca: Wire up PL031 RTC, Peter Maydell, 2019/02/14
- [Qemu-devel] [PATCH 12/14] hw/arm/musca: Add MPCs, Peter Maydell, 2019/02/14
- [Qemu-devel] [PATCH 11/14] hw/arm/musca: Add PPCs, Peter Maydell, 2019/02/14