[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 28/51] ipmi: express dependencies with kconfig
From: |
Corey Minyard |
Subject: |
Re: [Qemu-devel] [PATCH 28/51] ipmi: express dependencies with kconfig |
Date: |
Wed, 20 Feb 2019 08:06:33 -0600 |
User-agent: |
Mutt/1.9.4 (2018-02-28) |
On Thu, Feb 07, 2019 at 06:57:11PM +0100, Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini <address@hidden>
> Signed-off-by: Yang Zhong <address@hidden>
> Message-Id: <address@hidden>
> Reviewed-by: Thomas Huth <address@hidden>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> default-configs/i386-softmmu.mak | 3 ---
> default-configs/ppc64-softmmu.mak | 3 ---
> hw/ipmi/Kconfig | 6 ++++++
> 3 files changed, 6 insertions(+), 6 deletions(-)
This looks ok to me.
Reviewed-by: Corey Minyard <address@hidden>
>
> diff --git a/default-configs/i386-softmmu.mak
> b/default-configs/i386-softmmu.mak
> index 53e9d5e..e779ee1 100644
> --- a/default-configs/i386-softmmu.mak
> +++ b/default-configs/i386-softmmu.mak
> @@ -1,9 +1,6 @@
> # Default configuration for i386-softmmu
>
> CONFIG_VMXNET3_PCI=y
> -CONFIG_IPMI=y
> -CONFIG_IPMI_LOCAL=y
> -CONFIG_IPMI_EXTERN=y
> CONFIG_ISA_IPMI_KCS=y
> CONFIG_ISA_IPMI_BT=y
>
> diff --git a/default-configs/ppc64-softmmu.mak
> b/default-configs/ppc64-softmmu.mak
> index a0a9151..d642b67 100644
> --- a/default-configs/ppc64-softmmu.mak
> +++ b/default-configs/ppc64-softmmu.mak
> @@ -5,9 +5,6 @@ include ppc-softmmu.mak
>
> # For PowerNV
> CONFIG_POWERNV=y
> -CONFIG_IPMI=y
> -CONFIG_IPMI_LOCAL=y
> -CONFIG_IPMI_EXTERN=y
> CONFIG_ISA_IPMI_BT=y
>
> # For pSeries
> diff --git a/hw/ipmi/Kconfig b/hw/ipmi/Kconfig
> index 6a4f08f..b944fae 100644
> --- a/hw/ipmi/Kconfig
> +++ b/hw/ipmi/Kconfig
> @@ -3,14 +3,20 @@ config IPMI
>
> config IPMI_LOCAL
> bool
> + default y
> + depends on IPMI
>
> config IPMI_EXTERN
> bool
> + default y
> + depends on IPMI
>
> config ISA_IPMI_KCS
> bool
> depends on ISA_BUS
> + select IPMI
>
> config ISA_IPMI_BT
> bool
> depends on ISA_BUS
> + select IPMI
> --
> 1.8.3.1
>
>
>
- [Qemu-devel] [PATCH 05/51] kconfig: introduce kconfig files, (continued)
- [Qemu-devel] [PATCH 05/51] kconfig: introduce kconfig files, Paolo Bonzini, 2019/02/07
- [Qemu-devel] [PATCH 20/51] display: express dependencies with kconfig, Paolo Bonzini, 2019/02/07
- [Qemu-devel] [PATCH 27/51] sd: express dependencies with kconfig, Paolo Bonzini, 2019/02/07
- [Qemu-devel] [PATCH 28/51] ipmi: express dependencies with kconfig, Paolo Bonzini, 2019/02/07
- Re: [Qemu-devel] [PATCH 28/51] ipmi: express dependencies with kconfig,
Corey Minyard <=
- [Qemu-devel] [PATCH 22/51] vfio: express vfio dependencies with Kconfig, Paolo Bonzini, 2019/02/07
- [Qemu-devel] [PATCH 23/51] virtio: express virtio dependencies with Kconfig, Paolo Bonzini, 2019/02/07
- [Qemu-devel] [PATCH 25/51] isa: express SuperIO dependencies with Kconfig, Paolo Bonzini, 2019/02/07
- [Qemu-devel] [PATCH 26/51] ssi: express dependencies with kconfig, Paolo Bonzini, 2019/02/07
- [Qemu-devel] [PATCH 29/51] i386-softmmu.mak: remove all CONFIG_* except boards definitions, Paolo Bonzini, 2019/02/07
- [Qemu-devel] [PATCH 31/51] ppc: Express dependencies of the 'prep' and '40p' machines with kconfig, Paolo Bonzini, 2019/02/07
- [Qemu-devel] [PATCH 30/51] ppc64: Express dependencies of 'pseries' and 'powernv' machines with kconfig, Paolo Bonzini, 2019/02/07
- [Qemu-devel] [PATCH 32/51] ppc: Express dependencies of the Mac machines with kconfig, Paolo Bonzini, 2019/02/07
- [Qemu-devel] [PATCH 33/51] ppc: Express dependencies of the Sam460EX machines with kconfig, Paolo Bonzini, 2019/02/07