[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] shippable: fix build
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [PATCH] shippable: fix build |
Date: |
Wed, 20 Feb 2019 18:19:26 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 |
Hi Paolo,
Please also Cc reviewers :)
On 2/20/19 11:45 AM, Paolo Bonzini wrote:
> It looks like something in netmap has changed and compilation fails:
Partly my fault, I had the intention to add a git 'stable' tag for
reproducible builds [*] but forgot to add to my TODO list :/
[*] https://lists.gnu.org/archive/html/qemu-devel/2019-01/msg02028.html
>
> install -D libnetmap.a //usr/local/lib/libnetmap.a
> install: cannot stat libnetmap.a: No such file or directory
>
> Add an explicit "make" step to fix it.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> tests/docker/dockerfiles/debian-amd64.docker | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/docker/dockerfiles/debian-amd64.docker
> b/tests/docker/dockerfiles/debian-amd64.docker
> index 954fcf9606..df79f35a46 100644
> --- a/tests/docker/dockerfiles/debian-amd64.docker
> +++ b/tests/docker/dockerfiles/debian-amd64.docker
> @@ -33,7 +33,7 @@ RUN DEBIAN_FRONTEND=noninteractive eatmydata \
> apt-get install -y --no-install-recommends \
> linux-headers-amd64
> RUN git clone https://github.com/luigirizzo/netmap.git /usr/src/netmap
So the fix would be:
- RUN git clone https://github.com/luigirizzo/netmap.git /usr/src/netmap
+ RUN git clone https://github.com/luigirizzo/netmap.git /usr/src/netmap
&& \
git checkout v11.4
> -RUN cd /usr/src/netmap/LINUX && ./configure --no-drivers --no-apps
> --kernel-dir=$(ls -d /usr/src/linux-headers-*-amd64) && make install
> +RUN cd /usr/src/netmap/LINUX && ./configure --no-drivers --no-apps
> --kernel-dir=$(ls -d /usr/src/linux-headers-*-amd64) && make && make install
Your change doesn't hurt.
> ENV QEMU_CONFIGURE_OPTS --enable-netmap
>
> RUN ldconfig
>
Regards,
Phil.
Re: [Qemu-devel] [PATCH] shippable: fix build,
Philippe Mathieu-Daudé <=